From: Jiri Kosina <jikos@kernel.org>
To: Roderick Colenbrander <roderick@gaikai.com>
Cc: linux-input@vger.kernel.org, andreyknvl@google.com,
Roderick Colenbrander <roderick.colenbrander@sony.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] HID: sony: Fix memory corruption issue on cleanup.
Date: Thu, 5 Sep 2019 14:27:45 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.1909051427340.31470@cbobk.fhfr.pm> (raw)
In-Reply-To: <20190904212211.29832-1-roderick@gaikai.com>
On Wed, 4 Sep 2019, Roderick Colenbrander wrote:
> From: Roderick Colenbrander <roderick.colenbrander@sony.com>
>
> The sony driver is not properly cleaning up from potential failures in
> sony_input_configured. Currently it calls hid_hw_stop, while hid_connect
> is still running. This is not a good idea, instead hid_hw_stop should
> be moved to sony_probe. Similar changes were recently made to Logitech
> drivers, which were also doing improper cleanup.
>
> Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com>
> CC: stable@vger.kernel.org
Applied, thanks Roderick.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2019-09-05 12:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 21:22 [PATCH] HID: sony: Fix memory corruption issue on cleanup Roderick Colenbrander
2019-09-05 12:27 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.1909051427340.31470@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=andreyknvl@google.com \
--cc=linux-input@vger.kernel.org \
--cc=roderick.colenbrander@sony.com \
--cc=roderick@gaikai.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).