From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Kosina Subject: Re: [PATCH] HID: sony: Fix memory corruption issue on cleanup. Date: Thu, 5 Sep 2019 14:27:45 +0200 (CEST) Message-ID: References: <20190904212211.29832-1-roderick@gaikai.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20190904212211.29832-1-roderick@gaikai.com> Sender: stable-owner@vger.kernel.org To: Roderick Colenbrander Cc: linux-input@vger.kernel.org, andreyknvl@google.com, Roderick Colenbrander , stable@vger.kernel.org List-Id: linux-input@vger.kernel.org On Wed, 4 Sep 2019, Roderick Colenbrander wrote: > From: Roderick Colenbrander > > The sony driver is not properly cleaning up from potential failures in > sony_input_configured. Currently it calls hid_hw_stop, while hid_connect > is still running. This is not a good idea, instead hid_hw_stop should > be moved to sony_probe. Similar changes were recently made to Logitech > drivers, which were also doing improper cleanup. > > Signed-off-by: Roderick Colenbrander > CC: stable@vger.kernel.org Applied, thanks Roderick. -- Jiri Kosina SUSE Labs