From: Jiri Kosina <jikos@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: core: clean up indentation issue
Date: Mon, 23 Sep 2019 13:04:13 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.1909231303180.1459@cbobk.fhfr.pm> (raw)
In-Reply-To: <20190922115054.10880-1-colin.king@canonical.com>
On Sun, 22 Sep 2019, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is an if statement that is indented by one extra space,
> fix this by removing the extraneous space.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/hid/hid-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 3eaee2c37931..9469c382a182 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -2329,10 +2329,10 @@ int hid_add_device(struct hid_device *hdev)
> /*
> * Check for the mandatory transport channel.
> */
> - if (!hdev->ll_driver->raw_request) {
> + if (!hdev->ll_driver->raw_request) {
> hid_err(hdev, "transport driver missing .raw_request()\n");
> return -EINVAL;
> - }
> + }
Let's not pollute git blame and wait for an ocasion when we need to touch
the code for some more valid reason.
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2019-09-23 11:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-22 11:50 [PATCH] HID: core: clean up indentation issue Colin King
2019-09-23 11:04 ` Jiri Kosina [this message]
2019-09-25 11:47 ` Dan Carpenter
2019-09-27 10:04 ` Benjamin Tissoires
2019-09-27 10:04 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.1909231303180.1459@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).