From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB6C9C28CBC for ; Wed, 6 May 2020 09:42:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD05720838 for ; Wed, 6 May 2020 09:42:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588758134; bh=q6NKBEVy3YjLLZhfxK6WYMiLhm5hjtD+pDGV3+93BvA=; h=Date:From:To:cc:Subject:In-Reply-To:References:List-ID:From; b=duscnoBdXjO7YDFx/6aLwM1UYR3LLKbqDdnyE7P4WT9ITr9ooem8YHMNlnNUfiBRz rD8hR6l6Htp2Wvipe8WNQZgrONIFtJmKWT8AwkRljNAJItZsmmRy6pDr2QJd4JQZfu aWtCUUdgiuhoKkR6fyfCmCo+fWLWAxciPVlzN0tI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729088AbgEFJmO (ORCPT ); Wed, 6 May 2020 05:42:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:47814 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729134AbgEFJmO (ORCPT ); Wed, 6 May 2020 05:42:14 -0400 Received: from pobox.suse.cz (unknown [195.250.132.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F1F722082E; Wed, 6 May 2020 09:42:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588758133; bh=q6NKBEVy3YjLLZhfxK6WYMiLhm5hjtD+pDGV3+93BvA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=AWAUYiRgy9RPJXq85MjQxZ8ahN2JfC2kIz60PWwR4oQQG8nCPxFZg69EC/ysM8kxv 6iX3k4LU41qLkwoBkBZg8GiQ5YOBqxWpE442AR+Y3T3XxEp5VOuaHQAJ51lUYcqgaW mjRHhFuKY/G0Z2flRfhQdBt+DfAldVIyEfhJ/Uzg= Date: Wed, 6 May 2020 11:42:10 +0200 (CEST) From: Jiri Kosina To: Hans de Goede cc: Benjamin Tissoires , linux-input@vger.kernel.org Subject: Re: [PATCH 3/6] HID: asus: Add hid_is_using_ll_driver(usb_hid_driver) check In-Reply-To: <85945c78-5ed6-a780-e562-27c710710a8f@redhat.com> Message-ID: References: <20200428142254.252063-1-hdegoede@redhat.com> <20200428142254.252063-3-hdegoede@redhat.com> <85945c78-5ed6-a780-e562-27c710710a8f@redhat.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Wed, 6 May 2020, Hans de Goede wrote: > >> diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c > >> index b3292ff3f61a..719eff589f92 100644 > >> --- a/drivers/hid/hid-asus.c > >> +++ b/drivers/hid/hid-asus.c > >> @@ -842,7 +842,8 @@ static int asus_probe(struct hid_device *hdev, const > >> struct hid_device_id *id) > >> if (drvdata->quirks & QUIRK_IS_MULTITOUCH) > >> drvdata->tp = &asus_i2c_tp; > >> - if (drvdata->quirks & QUIRK_T100_KEYBOARD) { > >> + if ((drvdata->quirks & QUIRK_T100_KEYBOARD) && > >> + hid_is_using_ll_driver(hdev, &usb_hid_driver)) { > >> struct usb_interface *intf = to_usb_interface(hdev->dev.parent); > >> > > > > I am going to push the whole patchset to for-5.8/asus branch later today, > > Thanks. Now pushed out, thanks. > > but I guess this one should better be taken as 5.7 fix still, right? > > I know that Benjamin has been insisting on these extra checks, which > is why I added it. But in practice not having the check does not really > seem to be a big issue, so whether to add it to 5.7.x or not is your call. So I guess some wild device fuzzer might in theory be able to confuse it, but I don't immediately see how. So let's queue this all for 5.8. -- Jiri Kosina SUSE Labs