From: Jiri Kosina <jikos@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Nehal Shah <nehal-bakulchandra.shah@amd.com>,
Sandeep Singh <sandeep.singh@amd.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: sfh: fix address space confusion
Date: Mon, 4 Jan 2021 16:08:32 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2101041608141.13752@cbobk.fhfr.pm> (raw)
In-Reply-To: <20210103135418.3645344-1-arnd@kernel.org>
On Sun, 3 Jan 2021, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The new driver uses a phys_addr_t to store a DMA address,
> which does not work when the two are different size:
>
> drivers/hid/amd-sfh-hid/amd_sfh_client.c:157:11: error: incompatible pointer types passing 'phys_addr_t *' (aka 'unsigned int *') to parameter of type 'dma_addr_t *' (aka 'unsigned long long *') [-Werror,-Wincompatible-pointer-types]
> &cl_data->sensor_phys_addr[i],
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/dma-mapping.h:393:15: note: passing argument to parameter 'dma_handle' here
> dma_addr_t *dma_handle, gfp_t gfp)
> ^
>
> Change both the type and the variable name to dma_addr for consistency.
>
> Fixes: 4b2c53d93a4b ("SFH:Transport Driver to add support of AMD Sensor Fusion Hub (SFH)")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Good catch; queued for 5.11, thanks.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2021-01-04 15:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-03 13:53 [PATCH] HID: sfh: fix address space confusion Arnd Bergmann
2021-01-04 15:08 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2101041608141.13752@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nehal-bakulchandra.shah@amd.com \
--cc=sandeep.singh@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).