From: Jiri Kosina <jikos@kernel.org>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.or
Subject: Re: [PATCH] HID: add cmedia-fixup driver
Date: Thu, 15 Jul 2021 21:00:10 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2107152059330.8253@cbobk.fhfr.pm> (raw)
In-Reply-To: <20210704104906.78490-1-linux@weissschuh.net>
On Sun, 4 Jul 2021, Thomas Weißschuh wrote:
> This driver provides HID fixups for CMedia audio chips.
> For now this enables the recognition of the microphone mute button for the
> HS-100B.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> drivers/hid/Kconfig | 6 +++
> drivers/hid/Makefile | 1 +
> drivers/hid/hid-cmedia-fixup.c | 82 ++++++++++++++++++++++++++++++++++
> drivers/hid/hid-ids.h | 1 +
> drivers/hid/hid-quirks.c | 3 ++
> 5 files changed, 93 insertions(+)
> create mode 100644 drivers/hid/hid-cmedia-fixup.c
Can you please drop the '-fixup' from the driver name? We have quite a
couple of drivers that do report descriptor modifications, but we're not
using this '-fixup' naming scheme for them either.
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2021-07-15 19:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-04 10:49 [PATCH] HID: add cmedia-fixup driver Thomas Weißschuh
2021-07-15 19:00 ` Jiri Kosina [this message]
2021-07-15 19:08 ` Thomas Weißschuh
2021-07-15 19:14 ` Jiri Kosina
2021-07-15 19:45 ` Thomas Weißschuh
2021-07-20 8:11 ` Benjamin Tissoires
2021-07-20 8:12 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2107152059330.8253@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.or \
--cc=linux@weissschuh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).