From: Jiri Kosina <jikos@kernel.org>
To: "Vinícius Angiolucci Reis" <angiolucci@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
dmitry.torokhov@gmail.com
Subject: Re: [PATCH] Revert "HID: hid-asus.c: Maps key 0x35 (display off) to KEY_SCREENLOCK"
Date: Fri, 12 Nov 2021 11:28:48 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2111121128370.12554@cbobk.fhfr.pm> (raw)
In-Reply-To: <20211111224735.29665-1-angiolucci@gmail.com>
On Thu, 11 Nov 2021, Vinícius Angiolucci Reis wrote:
> This reverts commit 2ea5999d07d2a0ab6ad92ccf65524707f2c5e456.
>
> As Dmitry Torokhov pointed out, the previous code (KEY_DISPLAY_OFF) is
> actually correct. The real issue is that current desktop environments
> don't deal it properly. Mapping it to another event does not solve the
> issue.
>
> So I'm reverting that change, keeping key 0x35 mapped to KEY_DISPLAY_OFF
>
> Signed-off-by: Vinícius Angiolucci Reis <angiolucci@gmail.com>
Queued for 5.16-rc, thanks.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2021-11-12 10:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 22:47 [PATCH] Revert "HID: hid-asus.c: Maps key 0x35 (display off) to KEY_SCREENLOCK" Vinícius Angiolucci Reis
2021-11-12 10:28 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2111121128370.12554@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=angiolucci@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox