From: Jiri Kosina <jikos@kernel.org>
To: Andreas Bergmeier <abergmeier@gmx.net>
Cc: lains@riseup.net, benjamin.tissoires@redhat.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] HID: Send SwID in GetProtocolVersion
Date: Mon, 21 Nov 2022 22:35:18 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2211212235120.6045@cbobk.fhfr.pm> (raw)
In-Reply-To: <20221111194526.1375601-1-abergmeier@gmx.net>
On Fri, 11 Nov 2022, Andreas Bergmeier wrote:
> According to docs a SwID should be sent for GetProtocolVersion.
> > 0x10.DeviceIndex.0x00.0x1n
> where n is SwID
>
> Signed-off-by: Andreas Bergmeier <abergmeier@gmx.net>
> ---
> drivers/hid/hid-logitech-hidpp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
> index a0c148a8df6c..964a523c3de7 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -896,7 +896,7 @@ static int hidpp_root_get_protocol_version(struct hidpp_device *hidpp)
>
> ret = hidpp_send_rap_command_sync(hidpp,
> HIDPP_PAGE_ROOT_IDX,
> - CMD_ROOT_GET_PROTOCOL_VERSION,
> + CMD_ROOT_GET_PROTOCOL_VERSION | LINUX_KERNEL_SW_ID,
> ping_data, sizeof(ping_data), &response);
>
> if (ret == HIDPP_ERROR_INVALID_SUBID) {
Applied, thanks Andreas.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2022-11-21 21:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 19:45 [PATCH 1/1] HID: Send SwID in GetProtocolVersion Andreas Bergmeier
2022-11-14 14:19 ` Bastien Nocera
2022-11-21 21:35 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2211212235120.6045@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=abergmeier@gmx.net \
--cc=benjamin.tissoires@redhat.com \
--cc=lains@riseup.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox