From: Jiri Kosina <jikos@kernel.org>
To: Adrian Freund <adrian@freund.io>
Cc: kernel test robot <lkp@intel.com>,
linux-input@vger.kernel.org, oe-kbuild-all@lists.linux.dev,
linux-kernel@vger.kernel.org,
Basavaraj Natikar <basavaraj.natikar@amd.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Ivan Dovgal <iv.dovg@gmail.com>,
"Luke D . Jones" <luke@ljones.dev>
Subject: Re: [PATCH] HID: amd_sfh: Add support for tablet-mode-switch sensor
Date: Thu, 15 Dec 2022 11:26:46 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2212151125090.9000@cbobk.fhfr.pm> (raw)
In-Reply-To: <3447483d-11bc-8ab2-8aba-96870b42281b@freund.io>
On Thu, 15 Dec 2022, Adrian Freund wrote:
> > In file included from drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c:15:
> >>> drivers/hid/amd-sfh-hid/sfh1_1/../hid_descriptor/amd_sfh_hid_report_desc.h:649:17:
> >>> warning: 'tms_report_descriptor' defined but not used
> >>> [-Wunused-const-variable=]
> > 649 | static const u8 tms_report_descriptor[] = {
> > | ^~~~~~~~~~~~~~~~~~~~~
> hid_descriptor/amd_sfh_hid_report_desc.h is included from both
> hid_descriptor/amd_sfh_hid_desc.c and sfh1_1/amd_sfh_desc.c, the first of
> which has 4 usages of tms_report_descriptor. The later is for sensor fusion
> hub 1.1. I don't have access to a devices using sfh1.1, so I can't add support
> for the tablet mode switch there, causing the variable to be unused for that
> import.
I'd say either move the rdesc directly to
hid_descriptor/amd_sfh_hid_desc.c, or alternatively mark it with
__attribute__((used)).
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2022-12-15 10:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 21:41 [PATCH] HID: amd_sfh: Add support for tablet-mode-switch sensor Adrian Freund
[not found] ` <202212151621.e3OmYctb-lkp@intel.com>
2022-12-15 9:27 ` Adrian Freund
2022-12-15 10:26 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2212151125090.9000@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=adrian@freund.io \
--cc=basavaraj.natikar@amd.com \
--cc=benjamin.tissoires@redhat.com \
--cc=iv.dovg@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=luke@ljones.dev \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).