From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73E97EB64DD for ; Mon, 14 Aug 2023 09:14:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232486AbjHNJOD (ORCPT ); Mon, 14 Aug 2023 05:14:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234211AbjHNJNh (ORCPT ); Mon, 14 Aug 2023 05:13:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF2F6AD; Mon, 14 Aug 2023 02:13:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 41326648E3; Mon, 14 Aug 2023 09:13:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF27FC433C7; Mon, 14 Aug 2023 09:13:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692004415; bh=KEl0WjzhsYH00h3btT+tK17v6e+veb0lNNV8BHlMGfo=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Ao5OxByRCAkz/IF507lGgLQuDHYgQvIo0C/4fb/pnw3oDPpDSojqAdTwdmns/eoyt d5uescLUcYBKvgeEOTFjFu/R2PTvGXS32cisA7uXb9RTrCakfXJnEIVUHb+nEKOeup uwioltWhBflBbGjhfJJZiUJ99dYKvYVjhe09X9gmqOaHjAT2zfH4Tbb9aGV/WA7FKz N8lz8AFV8KpXrQju7x+HSUerpvbjJIu+hmPtYxaveUEINspMf0SeCOfQIuEv5TCGI4 xGcYtc3MpwGc01Mtx82hLD/aT7kMzBqdsbpvpLEEBlhAGVVO2oFWU1THUxOJW0BXGG eUKKJCKRdK0wQ== Date: Mon, 14 Aug 2023 11:13:31 +0200 (CEST) From: Jiri Kosina To: Daniel Thompson cc: Jonathan Cameron , Srinivas Pandruvada , Benjamin Tissoires , Bjorn Andersson , linux-input@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] HID: sensor-hub: Allow multi-function sensor devices In-Reply-To: <20230528092427.42332-1-daniel.thompson@linaro.org> Message-ID: References: <20230528092427.42332-1-daniel.thompson@linaro.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Sun, 28 May 2023, Daniel Thompson wrote: > The Lenovo Yoga C630 has a combined keyboard and accelerometer that > interfaces via i2c-hid. Currently this laptop either has a working > keyboard (if CONFIG_HID_SENSOR_HUB is disabled) or a working accelerometer. > only works on kernels. Put another way, most distro kernels enable > CONFIG_HID_SENSOR_HUB and therefore cannot work on this device since the > keyboard doesn't work! > > Fix this by providing a richer connect mask during the probe. With this > change both keyboard and screen orientation sensors work correctly. > > Signed-off-by: Daniel Thompson Applied. Sorry for the delay, -- Jiri Kosina SUSE Labs