linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Kosina <jikos@kernel.org>
To: Nils Tonnaett <ntonnatt@ccrma.Stanford.EDU>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Rahul Rameshbabu <sergeantsagara@protonmail.com>
Subject: Re: [PATCH v2] HID: apple: Add "Hailuck" to the list of non-apple keyboards
Date: Wed, 16 Aug 2023 15:21:08 +0200 (CEST)	[thread overview]
Message-ID: <nycvar.YFH.7.76.2308161521020.14207@cbobk.fhfr.pm> (raw)
In-Reply-To: <20230815201959.17569-1-ntonnatt@ccrma.stanford.edu>

On Tue, 15 Aug 2023, Nils Tonnaett wrote:

> Powzan keyboards KB750 and KB770 identify as
> "Hailuck Co.,Ltd USB Keyboard". Adding "Hailuck" to the list
> of non-apple keyboards fixes function keys for these models.
> 
> Signed-off-by: Nils Tonnaett <ntonnatt@ccrma.stanford.edu>
> ---
> V1 -> V2:
> 	- Start commit message subject with HID: apple: instead of hid:
> 	- Comma terminate last member of array
> 
>  drivers/hid/hid-apple.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
> index d7b932925730..3ca45975c686 100644
> --- a/drivers/hid/hid-apple.c
> +++ b/drivers/hid/hid-apple.c
> @@ -343,7 +343,8 @@ static const struct apple_non_apple_keyboard non_apple_keyboards[] = {
>  	{ "SONiX USB DEVICE" },
>  	{ "Keychron" },
>  	{ "AONE" },
> -	{ "GANSS" }
> +	{ "GANSS" },
> +	{ "Hailuck" },
>  };

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs


      parent reply	other threads:[~2023-08-16 13:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-11 20:29 [PATCH] hid: Add "Hailuck" to the list of non-apple apple keyboards Nils Tonnaett
2023-08-14  5:11 ` Rahul Rameshbabu
2023-08-15 20:19 ` [PATCH v2] HID: apple: Add "Hailuck" to the list of non-apple keyboards Nils Tonnaett
2023-08-16  2:23   ` Rahul Rameshbabu
2023-08-16 13:21   ` Jiri Kosina [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nycvar.YFH.7.76.2308161521020.14207@cbobk.fhfr.pm \
    --to=jikos@kernel.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ntonnatt@ccrma.Stanford.EDU \
    --cc=sergeantsagara@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).