Re: [PATCH hid-next] HID: amd_sfh: Fix build error without x86 kconfig

[Jiri Kosina <jikos@kernel.org>]

On Wed, 28 Feb 2024, Basavaraj Natikar wrote:

> >> diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
> >> index 9e97c26c4482..c815f2f54321 100644
> >> --- a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
> >> +++ b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
> >> @@ -410,8 +410,10 @@ static int amd_mp2_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i
> >>  
> >>  	privdata->sfh1_1_ops = (const struct amd_sfh1_1_ops *)id->driver_data;
> >>  	if (privdata->sfh1_1_ops) {
> >> +#ifdef CONFIG_X86
> >>  		if (boot_cpu_data.x86 >= 0x1A)
> >>  			privdata->rver = 1;
> >> +#endif
> > Does it even make sense to build this driver outside of x86 architecture?
> 
> Do you mean to say just add depends on X86 like below ?
> "
>  config AMD_SFH_HID
>         tristate "AMD Sensor Fusion Hub"
>         depends on HID
> +       depends on X86
>         help
>           If you say yes to this option, support will be included for the
>           AMD Sensor Fusion Hub.
> "

Yeah, that was my idea; as far as I understand, there is no way this 
driver would ever have any use outside of x86 architecture, right?

Thanks,

-- 
Jiri Kosina
SUSE Labs