From: Jiri Kosina <jikos@kernel.org>
To: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Cc: benjamin.tissoires@redhat.com, linux-input@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH hid-next] HID: amd_sfh: Set the AMD SFH driver to depend on x86
Date: Wed, 28 Feb 2024 13:11:23 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2402281311130.21798@cbobk.fhfr.pm> (raw)
In-Reply-To: <20240228113914.3864232-1-Basavaraj.Natikar@amd.com>
On Wed, 28 Feb 2024, Basavaraj Natikar wrote:
> Considering that amd_sfh exists only on AMD platforms, set the AMD SFH
> driver to depend on x86 to avoid build warnings or errors on other
> architectures, as shown below.
>
> drivers/hid/amd-sfh-hid/amd_sfh_pcie.c: In function 'amd_mp2_pci_probe':
> drivers/hid/amd-sfh-hid/amd_sfh_pcie.c:413:21: error: 'boot_cpu_data'
> undeclared (first use in this function); did you mean 'boot_cpu_hwid'?
> 413 | if (boot_cpu_data.x86 >= 0x1A)
> | ^~~~~~~~~~~~~
> | boot_cpu_hwid
>
> Fixes: 6296562f30b1 ("HID: amd_sfh: Extend MP2 register access to SFH")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Closes: https://lore.kernel.org/all/20240228145648.41c493ec@canb.auug.org.au/
> Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Applied, thanks.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2024-02-28 12:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 11:39 [PATCH hid-next] HID: amd_sfh: Set the AMD SFH driver to depend on x86 Basavaraj Natikar
2024-02-28 12:11 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2402281311130.21798@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=Basavaraj.Natikar@amd.com \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox