From: Jiri Kosina <jikos@kernel.org>
To: Max Staudt <max@enpas.org>
Cc: Roderick Colenbrander <roderick.colenbrander@sony.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] hid-playstation: DS4: Update rumble and lightbar together
Date: Wed, 21 Aug 2024 16:33:15 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2408211632590.12664@cbobk.fhfr.pm> (raw)
In-Reply-To: <20240820142529.9380-1-max@enpas.org>
On Tue, 20 Aug 2024, Max Staudt wrote:
> Some 3rd party gamepads expect updates to rumble and lightbar together,
> and setting one may cancel the other.
>
> Let's maximise compatibility for these controllers by sending rumble
> and lightbar updates together, even when only one has been scheduled.
>
> The quirky controllers are matched by a known CRC32 over their HID
> report descriptor (hdev->rdesc), since they seem to share the same
> descriptor, while pretending to be a Sony DS4 v2.0.
>
> Signed-off-by: Max Staudt <max@enpas.org>
Roderick, does you Ack from v2 still hold?
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2024-08-21 14:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 14:25 [PATCH v4] hid-playstation: DS4: Update rumble and lightbar together Max Staudt
2024-08-21 14:33 ` Jiri Kosina [this message]
2024-08-21 15:03 ` Roderick Colenbrander
2024-08-21 15:22 ` Max Staudt
2024-08-21 22:25 ` Jiri Kosina
2024-08-22 11:38 ` Max Staudt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2408211632590.12664@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max@enpas.org \
--cc=roderick.colenbrander@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).