linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chase Douglas <chase.douglas@canonical.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] input: ALPS - Add signature for HP Pavilion dm3 laptops
Date: Tue, 20 Apr 2010 23:47:20 -0400	[thread overview]
Message-ID: <r2x40ec3ea41004202047w9e5ae654xe375b67273a3f647@mail.gmail.com> (raw)
In-Reply-To: <l2s40ec3ea41004200601jd2772157ye1210e3d4764b199@mail.gmail.com>

On Tue, Apr 20, 2010 at 9:01 AM, Chase Douglas
<chase.douglas@canonical.com> wrote:
> On Tue, Apr 20, 2010 at 12:29 AM, Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
>> On Mon, Apr 19, 2010 at 01:36:33PM -0700, Chase Douglas wrote:
>>> After more testing, some users found that they no longer could use the
>>> vertical edge scroll of their touchpad. I assumed everything was
>>> working correctly because I had read a response to another user on
>>> this list that if you add a new ID, things work, and you don't see any
>>> protocol error messages in dmesg, then things should be correct. The
>>> testers reported no errors, so I assumed the problem was in the X
>>> synaptics driver. However, after receiving some event reports from a
>>> tester, it may be that the normal ps2 driver is still sending events,
>>> while the alps/synaptics kernel driver is not sending any. Do you have
>>> any insight on what might be going on?
>>>
>>
>> That means that our standard magic knock did not work. It seems that
>> newer version of ALPS are using a different "magic knock" sequence for
>> them.
>
> How can we find out what the new knock sequence is?

I've had more testing done by others with hardware. It's clear to me
that the magic knock sequence in alps.c does not work for this device.
I have tried both with ALPS_PASS as well, with no change. That means
that we have two potential ways to go from here:

a. Revert the signature and use the ImPS/2 Generic Wheel Mouse driver,
which provides wheel events automatically but without any absolute
event support
b. Leave the signature as is, which disables wheel events and enables
no extra functionality

I would call b a regression. Maybe we can figure out the new knock
protocol before the change propagates from tip to distros, but I think
it's better to revert the signature and reapply it later when we find
the right sequence. What do you think?

-- Chase

  reply	other threads:[~2010-04-21  3:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-27 17:51 [PATCH] input: ALPS - Add signature for HP Pavilion dm3 laptops Chase Douglas
2010-03-27 19:11 ` Dmitry Torokhov
2010-04-19 20:36   ` Chase Douglas
2010-04-20  7:29     ` Dmitry Torokhov
2010-04-20 13:01       ` Chase Douglas
2010-04-21  3:47         ` Chase Douglas [this message]
2010-04-21  4:10           ` Dmitry Torokhov
2010-04-21 12:15             ` Chase Douglas
2010-04-21 19:56               ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=r2x40ec3ea41004202047w9e5ae654xe375b67273a3f647@mail.gmail.com \
    --to=chase.douglas@canonical.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).