From: Takashi Iwai <tiwai@suse.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
patches@opensource.wolfsonmicro.com, linux-input@vger.kernel.org
Subject: Re: [PATCH v2] ALSA: ac97: Switch to dev_pm_ops
Date: Fri, 21 Aug 2015 18:27:08 +0200 [thread overview]
Message-ID: <s5hzj1ktxnn.wl-tiwai@suse.de> (raw)
In-Reply-To: <20150821161529.GB26302@localhost>
On Fri, 21 Aug 2015 18:15:29 +0200,
Dmitry Torokhov wrote:
>
> On Fri, Aug 21, 2015 at 10:25:59AM +0200, Takashi Iwai wrote:
> > On Fri, 21 Aug 2015 09:48:33 +0200,
> > Lars-Peter Clausen wrote:
> > >
> > > Convert the ac97_bus from legacy suspend/resume callbacks to dev_pm_ops.
> > >
> > > Since there isn't anything special to do at the bus level the bus driver
> > > does not have to implement any callbacks. The device driver core will
> > > automatically pick up and execute the device's PM ops.
> > >
> > > As there is only a single AC'97 driver implementing suspend and resume,
> > > update both the core and driver at the same time to avoid unnecessary code
> > > churn.
> > >
> > > While we are at it also drop the ifdefs around the suspend/resume functions
> > > to increase compile test coverage.
> > >
> > > Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> > > ---
> > > This patch touches code in both ALSA and the input subsystem. Ideally this
> > > patch will be merged via the ALSA tree. Given that the wm97xx touchscreen
> > > driver is not seeing too many changes these days the risk of conflicts
> > > should be low.
> >
> > If Dmitry is happy with this, I'll take this.
>
> Sounds good to me.
>
> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Mark, did you already put into your tree? Otherwise I'm going to take
it to for-next branch.
thanks,
Takashi
next prev parent reply other threads:[~2015-08-21 16:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 7:48 [PATCH v2] ALSA: ac97: Switch to dev_pm_ops Lars-Peter Clausen
2015-08-21 8:25 ` Takashi Iwai
2015-08-21 16:15 ` Dmitry Torokhov
2015-08-21 16:27 ` Takashi Iwai [this message]
2015-08-21 16:59 ` Mark Brown
2015-08-21 17:31 ` Takashi Iwai
2015-08-21 16:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hzj1ktxnn.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-input@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).