Re: [PATCH v5 2/3] HID: wiimote: replace spinlock pairs with scoped_guard

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] hid: incorrect preprocessor directive indentation
--

commit 6b73789c825ec316d85d88975b55b4fcb3448d0c
Author: Rafael Passos <rafael@rcpassos.me>

HID: wiimote: replace spinlock pairs with scoped_guard

This commit replaces manual lock/unlock sequences with scoped guards in the
wiimote driver. This is a cleanup that does not change behavior but aims to
make the code safer to modify in the future.

> diff --git a/drivers/hid/hid-wiimote-debug.c b/drivers/hid/hid-wiimote-debug.c
> index fc847c2a1c1f1..b8027bb236089 100644
> --- a/drivers/hid/hid-wiimote-debug.c
> +++ b/drivers/hid/hid-wiimote-debug.c
> @@ -7,12 +7,13 @@
>  /*
>   */
>  
> -#include <linux/debugfs.h>
> -#include <linux/module.h>
> -#include <linux/seq_file.h>
> -#include <linux/spinlock.h>
> -#include <linux/uaccess.h>
> -#include "hid-wiimote.h"
> + #include <linux/cleanup.h>
> + #include <linux/debugfs.h>
> + #include <linux/module.h>

[Severity: Low]
This isn't a bug, but could we remove the leading spaces before these #include
directives? The extra indentation violates the standard kernel coding style.

> + #include <linux/seq_file.h>
> + #include <linux/spinlock.h>
> + #include <linux/uaccess.h>
> + #include "hid-wiimote.h"

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009022844.2790778-1-rafael@rcpassos.me?part=2