Re: [PATCH v2 2/3] HID: asus: reinitialize the device after exiting a sleep state

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] hid: asus: missing backlight and OOBE restoration in reset_resume
--

commit fec26e5b201c893ff8605557f1064dad33a366a5
Author: Denis Benato <denis.benato@linux.dev>

HID: asus: reinitialize the device after exiting a sleep state

This commit adds report initialization logic when resuming from s2idle to
handle cases where the firmware completely turns off the USB device, such
as on the ROG Ally. It introduces an asus_initialize_reports() helper
called during probe and reset_resume.

> diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
> index baa8589d45ae2..e6218abdac49c 100644
> --- a/drivers/hid/hid-asus.c
> +++ b/drivers/hid/hid-asus.c

[ ... ]

> @@ -1403,6 +1425,9 @@ static int __maybe_unused asus_reset_resume(struct hid_device *hdev)
>  {
>  	struct asus_drvdata *drvdata = hid_get_drvdata(hdev);
>  
> +	if (!drvdata->tp)
> +		asus_initialize_reports(hdev);
> +
>  	if (drvdata->tp)
>  		return asus_start_multitouch(hdev);
>  
>  	return 0;
>  }

[Severity: Medium]
Does this miss restoring the backlight and OOBE disablement state?

When the system enters sleep and the USB device loses power, the USB PM
core will invoke asus_reset_resume() instead of asus_resume() upon waking.
While this commit adds report re-initialization here, it appears to miss
the backlight restoration and OOBE disablement.

For example, asus_resume() restores the keyboard backlight:

static int __maybe_unused asus_resume(struct hid_device *hdev)
{
	...
	if (drvdata->listener.brightness_set)
		asus_kbd_backlight_set(&drvdata->listener,
		                       drvdata->kbd_backlight_brightness);

	return 0;
}

Since asus_reset_resume() does not include this restoration, the keyboard
backlight may fail to turn back on after a hard reset or power loss during
sleep. Can we safely mirror the restore sequence from asus_resume() here?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009114921.5242-1-denis.benato@linux.dev?part=2