Re: [PATCH v9 01/12] HID: asus: reinitialize the device after exiting a sleep state

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] hid: asus: missing backlight restoration in asus_reset_resume
--

commit db57f630fbe7f986dca53a47a7465f75b0c3eaab
Author: Denis Benato <denis.benato@linux.dev>

HID: asus: reinitialize the device after exiting a sleep state

The ROG ally needs to have the EC string sent back after resuming from
s2idle since the USB device can be turned completely off by the firmware
when mcu_powersave firmware-attribute is set to 1. This patch reinitializes
the reports upon device reset resume.

> diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
> index 7dc6417fe2622..1e430ddb8605b 100644
> --- a/drivers/hid/hid-asus.c
> +++ b/drivers/hid/hid-asus.c

[ ... ]

> @@ -1379,6 +1401,9 @@ static int __maybe_unused asus_reset_resume(struct hid_device *hdev)
>  {
>  	struct asus_drvdata *drvdata = hid_get_drvdata(hdev);
>  
> +	if (!drvdata->tp)
> +		asus_initialize_reports(hdev);
> +
>  	if (drvdata->tp)
>  		return asus_start_multitouch(hdev);
>  

[Severity: Low]
Since this function handles device re-initialization after power is lost
during sleep (e.g., s2idle with mcu_powersave enabled), does it also need
to restore the backlight state?

Looking at asus_resume() in the same file, it explicitly restores the
keyboard backlight:

static int __maybe_unused asus_resume(struct hid_device *hdev)
{
    ...
    if (drvdata->listener.brightness_set)
        asus_kbd_backlight_set(&drvdata->listener,
                               drvdata->kbd_backlight_brightness);
    ...
}

Will the keyboard backlight remain off if the system wakes up from a sleep
state where USB device power was cut and the USB core issues a reset_resume
rather than a standard resume?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009122820.7603-1-denis.benato@linux.dev?part=1