Re: [PATCH] Input: xpad - add GameSir Nova Lite support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] xpad: xpad_device array is not sorted by product ID
--

commit 375f6defb6771387f96405b8a84408224531a65c
Author: Francesco Orlando <francesco.orlando99@libero.it>

Input: xpad - add GameSir Nova Lite support

This commit adds the vendor and product ID (0x3537:0x1040) for the GameSir
Nova Lite controller in XInput mode. This addition enables force feedback
rumble support for the device.

> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index 6406ceab988ad..00a26693ded61 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -403,6 +403,7 @@ static const struct xpad_device {
>  	{ 0x3285, 0x0663, "Nacon Evol-X", 0, XTYPE_XBOXONE },
>  	{ 0x3507, 0x000b, "ZENAIM LEVERLESS", 0, XTYPE_XBOX360 },
>  	{ 0x3537, 0x1004, "GameSir T4 Kaleid", 0, XTYPE_XBOX360 },
> +	{ 0x3537, 0x1040, "GameSir Nova Lite", 0, XTYPE_XBOX360 },
>  	{ 0x3537, 0x100f, "GameSir Nova 2 Lite", 0, XTYPE_XBOX360 },
>  	{ 0x3537, 0x1010, "GameSir G7 SE", 0, XTYPE_XBOXONE },

[Severity: Low]
This isn't a bug, but could this entry be placed further down to maintain the
requested numerical sorting order?

The comment preceding the xpad_device array explicitly states:
/* Please keep this list sorted by vendor and product ID. */

The new entry for the GameSir Nova Lite with product ID 0x1040 is inserted
between 0x1004 and 0x100f. Since 0x1040 is numerically greater than 0x100f
and 0x1010, it should probably be placed after the entry for 0x1010 to
maintain the ascending numerical sort order for vendor 0x3537.

>  	{ 0x3651, 0x1000, "CRKD SG", 0, XTYPE_XBOX360 },

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261011153422.66844-1-francesco.orlando99@libero.it?part=1