Re: [PATCH v5 7/7] arm64: dts: qcom: generalmobile-shamrock: new device

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] arm64: dts: missing status="okay" for blsp1_uart2 console
- [Medium] arm64: dts: missing status="okay" for primary usb controller
--

commit d4818cfa8bc0f829c17bbc9440ca720d3616017e
Author: Muzaffer Kadir <muzafferkadir@mainlining.org>

arm64: dts: qcom: generalmobile-shamrock: new device

Add General Mobile Shamrock (GM 5 Plus). Shamrock is designed similar to
L9300.

> diff --git a/arch/arm64/boot/dts/qcom/msm8952-generalmobile-shamrock.dts b/arch/arm64/boot/dts/qcom/msm8952-generalmobile-shamrock.dts
> new file mode 100644
> index 0000000000000..9114b232cb1bb
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/msm8952-generalmobile-shamrock.dts
[ ... ]
> +	aliases {
> +		mmc0 = &sdhc_1; /* SDC1 eMMC slot */
> +		mmc1 = &sdhc_2; /* SDC2 SD card slot */
> +		serial0 = &blsp1_uart2;

[Severity: High]
This defines the serial alias for the console in the aliases node, but the
target node is never enabled in msm8952-generalmobile-shamrock.dts.

The blsp1_uart2 node defaults to status = "disabled" in the upstream
msm8952.dtsi and is never overridden to status = "okay" in this board file.

Will this cause the serial console to fail to probe, breaking standard serial
output and early debugging?

> +	};
[ ... ]
> +&blsp2_i2c1 {
> +	status = "okay";
> +
> +	/* FUSB301 @25 USB-C Controller */
> +
> +	tpa6130a2: audio-controller@60 {
> +		compatible = "ti,tpa6130a2";
> +		reg = <0x60>;
> +		pinctrl-0 = <&tpa6130a2_default>;
> +		pinctrl-names = "default";
> +		power-gpio = <&tlmm 61 GPIO_ACTIVE_HIGH>;
> +		Vdd-supply = <&pm8950_l22>;
> +	};
> +
> +	tusb320: usb@67 {
> +		compatible = "ti,tusb320";

[Severity: Medium]
A Type-C port controller is instantiated here in blsp2_i2c1, clearly indicating
USB functionality is present on this device.

However, the overarching &usb controller node is left disabled (its default
state in msm8952.dtsi).

Without enabling the main USB controller node with status = "okay" in
msm8952-generalmobile-shamrock.dts, will USB data communication remain
completely broken?

> +		reg = <0x67>;
> +		interrupts-extended = <&tlmm 45 IRQ_TYPE_EDGE_FALLING>;
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261011-msm8952-initial-support-v5-0-1857074992ec@mainlining.org?part=7