Re: [PATCH v4] HID: logitech-headset: add a battery driver for the PRO X 2

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] kconfig: unmet direct dependency on USB_HID for HID_LOGITECH_HEADSET
--

commit d9d20c74276791f547d49f85750e9fd359bb8c0c
Author: Méven Car <meven29@gmail.com>
Subject: HID: logitech-headset: add a battery driver for the PRO X 2

The PRO X 2 LIGHTSPEED receiver does not speak HID++, so
hid-logitech-hidpp cannot read its battery. Its report descriptor has a
consumer collection for the media keys and two vendor collections, and
no report 0x10 or 0x11.

> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 0e3a0ccd6901e..60f579be1da69 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -680,6 +680,7 @@ config HID_LOGITECH_DJ
>  	depends on HIDRAW
>  	depends on HID_LOGITECH
>  	select HID_LOGITECH_HIDPP
> +	select HID_LOGITECH_HEADSET
>  	help
>  	Say Y if you want support for Logitech receivers and devices.
>  	Logitech receivers are capable of pairing multiple Logitech compliant

[ ... ]

> @@ -687,6 +688,18 @@ config HID_LOGITECH_DJ
>  	generic USB_HID driver and all incoming events will be multiplexed
>  	into a single mouse and a single keyboard device.
>  
> +config HID_LOGITECH_HEADSET
> +	tristate
> +	depends on USB_HID
> +	select POWER_SUPPLY
> +	help

[Severity: Low]
Could this select statement in HID_LOGITECH_DJ cause an unmet direct dependency
warning?

HID_LOGITECH_DJ unconditionally selects HID_LOGITECH_HEADSET, but
HID_LOGITECH_HEADSET specifies a direct dependency on USB_HID. 

Because Kconfig's select directive forces the symbol on without evaluating its
dependencies, enabling HID_LOGITECH_DJ in a configuration lacking USB_HID will
produce an 'unmet direct dependencies' build warning.

Should HID_LOGITECH_DJ inherit the dependency on USB_HID, or should the select
be conditional?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016114757.1099300-1-meven@kde.org?part=1