Re: [PATCH v2] HID: intel-thc-hid: validate ACPI buffer length before memcpy

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] HID: intel-thc-hid: missing @buf_size kernel-doc in ACPI helpers
--

commit 43947a3c4aa80586265415752a6a772f3e74da02
Author: Tristan Madani <tristan@talencesecurity.com>

HID: intel-thc-hid: validate ACPI buffer length before memcpy

This commit adds a buf_size parameter to the QuickI2C and QuickSPI ACPI
helper functions to validate returned buffer lengths before copying them into
destination structures. It also adds missing ACPI object type validation and
memory cleanup in quicki2c_acpi_get_dsd_property(), and zero-initializes the
caller stack structures.

> diff --git a/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c b/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
> index 7a913f717efaa..dd21864d16b05 100644
> --- a/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
> +++ b/drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c
> @@ -62,7 +62,8 @@ static const struct acpi_gpio_mapping quicki2c_gpios[] = {
>   * Return: 0 if success or ENODEV on failure.
>   */
>  static int quicki2c_acpi_get_dsm_property(struct acpi_device *adev, const guid_t *guid,
> -					  u64 rev, u64 func, acpi_object_type type, void *prop_buf)
> +					  u64 rev, u64 func, acpi_object_type type,
> +					  void *prop_buf, size_t buf_size)
>  {

[ ... ]

> @@ -97,7 +103,8 @@ static int quicki2c_acpi_get_dsm_property(struct acpi_device *adev, const guid_t
>   * Return: 0 if success or ENODEV on failed.
>   */
>  static int quicki2c_acpi_get_dsd_property(struct acpi_device *adev, acpi_string dsd_method_name,
> -					  acpi_object_type type, void *prop_buf)
> +					  acpi_object_type type, void *prop_buf,
> +					  size_t buf_size)
>  {

[ ... ]

> diff --git a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
> index 53023e30cf8d4..e4331ba4e503d 100644
> --- a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
> +++ b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
> @@ -81,7 +81,8 @@ static const struct acpi_gpio_mapping quickspi_gpios[] = {
>   * Return: 0 if successful or ENODEV on failed.
>   */
>  static int thc_acpi_get_property(struct acpi_device *adev, const guid_t *guid,
> -				 u64 rev, u64 func, acpi_object_type type, void *prop_buf)
> +				 u64 rev, u64 func, acpi_object_type type,
> +				 void *prop_buf, size_t buf_size)
>  {

[Severity: Low]
Should the kernel-doc comments above quicki2c_acpi_get_dsm_property() and
quicki2c_acpi_get_dsd_property() in
drivers/hid/intel-thc-hid/intel-quicki2c/pci-quicki2c.c, as well as
thc_acpi_get_property() in
drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c, be updated to
describe the new @buf_size parameter?

Without @buf_size in those kernel-doc blocks, building with W=1 or running
scripts/kernel-doc triggers warnings that the function parameter buf_size is
not described.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261025154745.2734805-1-tristmd@gmail.com?part=1