Re: [PATCH v3 1/2] rust: input: add input device abstractions

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] rust: input: non-vertical crate import formatting in input.rs
--

commit d03870e71b5fd937f97b178433700c90c89f7646
Author: clicedvly768 <harepro29@gmail.com>

rust: input: add input device abstractions

This commit adds safe Rust abstractions for Linux input devices,
including AllocatedDevice for pre-registration configuration and
RegisteredDevice for event reporting and cleanup.

> diff --git a/rust/kernel/input.rs b/rust/kernel/input.rs
> new file mode 100644
> index 0000000000000..707f2af3110d6
> --- /dev/null
> +++ b/rust/kernel/input.rs
> @@ -0,0 +1,248 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +//! Input subsystem abstractions for safe Rust drivers.
> +//!
> +//! Provides a safe Rust object-oriented interface around Linux `struct input_dev`,
> +//! ensuring safe allocation, capability configuration, registration, and RAII cleanup.
> +
> +use crate::{bindings, device, error::to_result, prelude::*};

[Severity: Low]
This isn't a bug, but multi-item crate imports in kernel Rust code should
use the vertical layout with a trailing empty comment (//) per
Documentation/rust/coding-guidelines.rst so rustfmt keeps each imported
item on its own line.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106211034.401918-1-harepro29@gmail.com?part=1