Re: [PATCH v7 2/2] rust: serio: add serio bus abstractions and port Gravis Stinger driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] rust: serio: non-existent crate::bindings::irqreturn::IRQ_* in
  mod bindings
--

commit e108571e336aa2835a298065109700e94f7a4ab9
Author: Vecheslav Filatov <harepro29@gmail.com>

rust: serio: add serio bus abstractions and port Gravis Stinger driver

This commit adds Rust abstractions for the serio bus subsystem and ports
the Gravis Stinger serial gamepad driver to Rust.

> diff --git a/rust/kernel/serio.rs b/rust/kernel/serio.rs
> new file mode 100644
> index 0000000000000..dc0de5f527158
> --- /dev/null
> +++ b/rust/kernel/serio.rs
> @@ -0,0 +1,341 @@

[ ... ]

> +mod bindings {
> +    pub(super) use crate::bindings::*;
> +
> +    #[allow(non_upper_case_globals)]
> +    pub(super) const irqreturn_IRQ_NONE: crate::bindings::irqreturn_t =
> +        crate::bindings::irqreturn::IRQ_NONE;
> +    #[allow(non_upper_case_globals)]
> +    pub(super) const irqreturn_IRQ_HANDLED: crate::bindings::irqreturn_t =
> +        crate::bindings::irqreturn::IRQ_HANDLED;
> +}

[Severity: High]
Does this fail to build when CONFIG_RUST=y and CONFIG_SERIO=y are enabled?

bindgen generates crate::bindings::irqreturn as a type alias for c_uint
and exposes the enum variants as top-level constants
crate::bindings::irqreturn_IRQ_NONE and
crate::bindings::irqreturn_IRQ_HANDLED (as used in
rust/kernel/irq/request.rs). Referencing crate::bindings::irqreturn::IRQ_*
fails to compile with E0599 and shadows the existing top-level constants;
importing crate::bindings directly avoids the need for this wrapper
module.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261107063520.489958-1-harepro29@gmail.com?part=2