Re: [PATCH v8 2/2] rust: serio: add serio bus abstractions and port Gravis Stinger driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] rust: serio: non-existent bindings::irqreturn::IRQ_* paths
  break build
--

commit 7de59dece60ff6273292c2ada6f83924d551c7fd
Author: Vecheslav Filatov <harepro29@gmail.com>

rust: serio: add serio bus abstractions and port Gravis Stinger driver

This commit adds Rust abstractions for the serio bus subsystem and ports the
Gravis Stinger serial gamepad driver to Rust.

> diff --git a/rust/kernel/serio.rs b/rust/kernel/serio.rs
> new file mode 100644
> index 0000000000000..4e16917ddd70c
> --- /dev/null
> +++ b/rust/kernel/serio.rs
[ ... ]
> +pub use crate::irq::IrqReturn;
> +
> +#[allow(non_upper_case_globals)]
> +const irqreturn_IRQ_NONE: bindings::irqreturn_t = bindings::irqreturn::IRQ_NONE;
> +#[allow(non_upper_case_globals)]
> +const irqreturn_IRQ_HANDLED: bindings::irqreturn_t = bindings::irqreturn::IRQ_HANDLED;

[Severity: High]
Does this fail to build when CONFIG_RUST=y and CONFIG_SERIO=y are enabled?
bindgen generates bindings::irqreturn as a u32 type alias with flat top-level
constants bindings::irqreturn_IRQ_NONE and bindings::irqreturn_IRQ_HANDLED
(as used in rust/kernel/irq/request.rs), so resolving associated items
IRQ_NONE and IRQ_HANDLED on bindings::irqreturn fails with E0599.  Dropping
these local constants and using bindings::irqreturn_IRQ_NONE and
bindings::irqreturn_IRQ_HANDLED directly in Registration::interrupt_callback()
will fix the build.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261107070010.500128-1-harepro29@gmail.com?part=2