Re: [PATCH 1/5] Input: s6sy761 - apply the touchscreen inversion and swap properties

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found no new issues
in this patch, but noticed 1 related pre-existing issue it does not
introduce:
- [High] Input: s6sy761 - premature input_sync() in
  s6sy761_report_coordinates() [1]
--

commit a5e7ac4e0cb3d02e12af7f249f64b3074df9f280
Author: Nizat Mikayilli <nacht@dxdmail.cc>

Input: s6sy761 - apply the touchscreen inversion and swap properties

This commit replaces raw X and Y coordinate reporting with
touchscreen_report_pos() so touchscreen inversion and axis swap properties
take effect.

> diff --git a/drivers/input/touchscreen/s6sy761.c b/drivers/input/touchscreen/s6sy761.c
> index 1afa38850f12f..967fd222f0d62 100644
> --- a/drivers/input/touchscreen/s6sy761.c
> +++ b/drivers/input/touchscreen/s6sy761.c
> @@ -153,8 +153,7 @@ static void s6sy761_report_coordinates(struct s6sy761_data *sdata,
>  	input_mt_slot(sdata->input, tid);
>  
>  	input_mt_report_slot_state(sdata->input, MT_TOOL_FINGER, true);
> -	input_report_abs(sdata->input, ABS_MT_POSITION_X, x);
> -	input_report_abs(sdata->input, ABS_MT_POSITION_Y, y);
> +	touchscreen_report_pos(sdata->input, &sdata->prop, x, y, true);
>  	input_report_abs(sdata->input, ABS_MT_TOUCH_MAJOR, major);
>  	input_report_abs(sdata->input, ABS_MT_TOUCH_MINOR, minor);
>  	input_report_abs(sdata->input, ABS_MT_PRESSURE, z);

[Severity: High]
This problem wasn't introduced by this patch, but does calling
input_sync() at the end of s6sy761_report_coordinates() and
s6sy761_report_release() fragment multi-finger updates [1]?

drivers/input/touchscreen/s6sy761.c:s6sy761_report_coordinates() {
	...
	input_report_abs(sdata->input, ABS_MT_PRESSURE, z);

	input_sync(sdata->input);
}

When s6sy761_irq_handler() loops over batched events, emitting SYN_REPORT
inside each per-slot helper splits a single multi-finger hardware update
into multiple torn frames for userspace.

[1] https://sashiko.dev/#/bug/linux-c1c813ff-e5e5-43df-a3c3-af15e2a7dad5

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261108-b4-s6sy761-fts1ba90a-v1-0-999b3cfaf82d@dxdmail.cc?part=1