Re: [PATCH v2 7/9] HID: Add hid-plugin framework for loadable plugin modules

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] HID: hid-plugin: missing Return section in hid_plugin_register()
  kernel-doc
--

commit ea30651fd5d31e4684e4f118c37b9199cf1158fc
Author: Rong Zhang <i@rong.moe>

HID: Add hid-plugin framework for loadable plugin modules

This commit introduces a hid-plugin framework that allows HID drivers to
request optional loadable or builtin plugin modules via RCU and module
reference counting.

Link: https://lore.kernel.org/linux-input/auypydfkhx2eg7vp764way4batdilzc35inqda3exwzs3tk3ff@oagat6g46zto/

> diff --git a/drivers/hid/hid-plugin.h b/drivers/hid/hid-plugin.h
> new file mode 100644
> index 0000000000000..4038325c51a08
> --- /dev/null
> +++ b/drivers/hid/hid-plugin.h

[ ... ]

> +/**
> + * hid_plugin_register() - Register an HID plugin.
> + * @id: Unique ID of @plugin
> + * @plugin: Pointer to the HID plugin
> + */
> +static __always_inline int hid_plugin_register(enum hid_plugin_id id, struct hid_plugin *plugin)
> +{
> +	BUILD_BUG_ON(!hid_plugin_enabled(id));
> +
> +	return __hid_plugin_register(id, plugin);
> +}

[Severity: Low]
The kernel-doc comment for hid_plugin_register() omits a Return: section,
which causes a kernel-doc warning when building with W=1.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110-hid-haptic-kmod-v2-0-b835a067cb62@rong.moe?part=7