Linux Input/HID development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: tuhaowen <tuhaowen@uniontech.com>
Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH] HID: mcp2221: Keep IIO initialization retries per device
Date: Fri, 13 Nov 2026 01:45:07 +0000	[thread overview]
Message-ID: <sashiko-outbox-212073@kernel.org> (raw)
In-Reply-To: <4861CDE55CCD8365+20261113014036.1430473-1-tuhaowen@uniontech.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] HID: mcp2221: Signed-off-by and Author use account handle
  instead of real name
--

commit 0750e741db2254c14f91e93fd256287b28060c69
Author: tuhaowen <tuhaowen@uniontech.com>

> HID: mcp2221: Keep IIO initialization retries per device
>
> mcp_init_work() uses a static retry counter, so all MCP2221 devices share
> the same retry budget. Initializing one device can exhaust the retries
> available to another device, including a new instance after unplugging
> and reconnecting the bridge.
>
> When the counter reaches zero, the post-decrement also changes it to -1.
> A subsequent instance that receives -EAGAIN will then keep rescheduling
> its initialization work instead of stopping at the intended limit.
> Different devices can also update the shared counter concurrently.
>
> Store the retry budget in struct mcp2221 and initialize it before queuing
> the IIO initialization work. Check for exhaustion before decrementing so
> the counter stays at zero once the retry limit is reached.
>
> Fixes: 960f9df7c620 ("HID: mcp2221: add ADC/DAC support via iio subsystem")
> Signed-off-by: tuhaowen <tuhaowen@uniontech.com>

[Severity: High]
The Author header and Signed-off-by trailer use the single-word account
handle "tuhaowen" instead of a full real name, which does not meet the
Developer's Certificate of Origin requirements in
Documentation/process/submitting-patches.rst.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/4861CDE55CCD8365+20261113014036.1430473-1-tuhaowen@uniontech.com?part=1

      reply	other threads:[~2026-11-13  1:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13  1:40 [PATCH] HID: mcp2221: Keep IIO initialization retries per device tuhaowen
2026-11-13  1:45 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-212073@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=tuhaowen@uniontech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox