From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794921134; b=z9TxmKoJZnl66QSqscmRRQAiylOa34LoFEtQ/cEz8jQZgsS4+y5VmKWBbEzzrKgKAqEz 6Ar8wuXR3rki9MhYsyEJbEDzRz9u+vfxy8jK+tvnhRQvShrqAZ92wyPUE99ogvJh+ZD12 uTtb5+En4pNDws3/DHw8c0RGygehfcbdiDYzaQctT9GtQx4ZTtPo92lqFSBcUM84p0k0y fc19N1tOA7MiQcu99vNCjmdbXfhdXZrwO4z2LxFLz0NwfIWrQ1hBxgO01arz2z4jPaed7 Kgn93KIRrnqbe10jgJv1FImniN9TuLYk1DTlR7s/aeFaGLk3XEJExY+Phfm3ltwTBzQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794921134; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=iJBQqRQzoXZT7PfdBPjYwSNCpOqgJZva0MpxKAl1fCE=; b=c6/Ki4n6PKmSCBHzyIEKm3ro8nG89MmpFkE5YHFqMYiQukMtnePGnzgtIR+LTGxG/MF8 9mgNh5iN0h6aKp4judZgVjDWZ+IbhYd9CTtZnU/QqfcCgonCU0NSjbUSDdS6oG8mjQgr0 t69a0zX3lJhQJ7E0bFsH3uox+9LptVnHiJa2M3f/sNW9YyHteaCU0r6ZTKbbsWf6ABjVB jBR1fiyoahYqVcZWd9Wzb2Yi5qxxfrwKtOZD8O5y58raqKyVP1ET2DjXrUXkNZD5yiCnU pjn+bN61DrkQpvbELHhUPN8XCIWoa9M4nsuFHm983s/WutHwGaOd3fmJBxWYwa52LCw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=in01Ju3q; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9CE3606A323; Tue, 17 Nov 2026 13:12:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=in01Ju3q Received: by smtp.kernel.org (Postfix) with ESMTPSA id 184881F000C5; Tue, 17 Nov 2026 13:12:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794921134; bh=iJBQqRQzoXZT7PfdBPjYwSNCpOqgJZva0MpxKAl1fCE=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=in01Ju3qLR3T6hfnJlSnS+nq81QNlcX84Wzx8Go2ErJtbvaZUQ6bmlXQ2T01ZBFdG QZpIMKm8dyI06357sBFbLPeqJqg3Qhq06xkxjg3ZqYQNOfzE9BGccdIStUAar0pA+4 a5RtOYHLlWAYtupOEfLENgoeYagaNibuOHs0BIDX38P/MGGw+BbSg8/QjqQKgaqimj SxcFQn11xs65WLPrQoYIFzPNXeBCOvf/7ya+FESQmZuDZsw+J0vRgqsueT4u61risS 6x+A+legurLCCLSlsc4brtpJZgCmEt7qQuLbU0hPcbforWolfe+vcB0JfBZHuskvzr ic9TWTz9T9l0Q== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v1 10/11] arm64: dts: qcom: sm8250-lge-timelm: enable USB Type-C Reply-To: sashiko-reviews@lists.linux.dev To: rofikkerneldev Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, dmitry.torokhov@gmail.com In-Reply-To: <20261117123946.668557-11-rofikcoga@gmail.com> References: <20261117123946.668557-1-rofikcoga@gmail.com> <20261117123946.668557-11-rofikcoga@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 17 Nov 2026 13:12:13 +0000 X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 4 potential issues to consider: - [High] arm64: dts: qcom: username handle used in Signed-off-by trailer - [High] arm64: dts: qcom: sm8250-lge-timelm: missing OF graph ports in usb-c-connector - [High] arm64: dts: qcom: sm8250-lge-timelm: PDO_BATT in sink-pdos breaks 9V PD current - [Medium] arm64: dts: qcom: sm8250-lge-timelm: swapped supplies in usb_1_qmpphy -- commit 81ec31057ff34acf5ea3063aab5a376e5f194531 Author: rofikkerneldev > arm64: dts: qcom: sm8250-lge-timelm: enable USB Type-C > > Enable the PM8150B Type-C controller as a sink-only port. Keep the > primary DWC3 controller in peripheral mode for now; host mode and VBUS > sourcing can be enabled after OTG power delivery is validated. > > Signed-off-by: rofikkerneldev [Severity: High] Under Documentation/process/submitting-patches.rst, the Developer's Certificate of Origin requires a real human name rather than an account handle in the Author header and Signed-off-by trailer. > diff --git a/arch/arm64/boot/dts/qcom/sm8250-lge-timelm.dts b/arch/arm64/= boot/dts/qcom/sm8250-lge-timelm.dts > index a094aa81ad225..6b57c658cf918 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250-lge-timelm.dts > +++ b/arch/arm64/boot/dts/qcom/sm8250-lge-timelm.dts > @@ -535,6 +535,24 @@ &sdhc_2 { > no-mmc; > }; > =20 > +&pm8150b_typec { > + status =3D "okay"; > + > + vdd-pdphy-supply =3D <&vreg_l2a_3p1>; > + > + connector { > + compatible =3D "usb-c-connector"; > + > + power-role =3D "sink"; > + data-role =3D "device"; > + self-powered; > + > + op-sink-microwatt =3D <15000000>; > + sink-pdos =3D + PDO_BATT(5000, 9000, 15000)>; [Severity: High] Should the second entry in sink-pdos use PDO_VAR() or PDO_FIXED() instead of PDO_BATT()? PDO_BATT(5000, 9000, 15000) encodes 15000 mW in bits [9:0] in 250 mW units (value 60). When connected to a standard USB-PD adapter advertising a 9V PDO_TYPE_FIXED source PDO, tcpm_pd_select_pdo() matches that 9V source PDO against this sink PDO by voltage range, and tcpm_pd_build_request() then checks the source PDO type: drivers/usb/typec/tcpm/tcpm.c:tcpm_pd_build_request() { ... type =3D pdo_type(pdo); ... if (type =3D=3D PDO_TYPE_BATT) { mw =3D min_power(pdo, matching_snk_pdo); ma =3D 1000 * mw / mv; } else { ma =3D min_current(pdo, matching_snk_pdo); mw =3D ma * mv / 1000; } } Because the source PDO is PDO_TYPE_FIXED, min_current() calls pdo_max_current(matching_snk_pdo), which interprets bits [9:0] in 10 mA units. That clamps the requested current at 9V to 600 mA (5.4 W instead of 15 W) and sets RDO_CAP_MISMATCH. > + }; > +}; [Severity: High] Is the connector node missing its ports subnode linking port@0 to usb_1_dwc3_hs_out and port@1 to usb_1_qmpphy_out (along with the matching remote-endpoint properties on those nodes)? In qcom_pmic_typec_port_set_polarity(), the PM8150B TCPC driver does not program SuperSpeed lane polarity itself and leaves orientation switching to usb_1_qmpphy, which registers a Type-C orientation switch and mux in qmp_combo_probe(). Without the OF graph endpoints under connector, fwnode_typec_switch_get(), fwnode_typec_mux_get() and fwnode_usb_role_switch_get() find no matches and return NULL. When a Type-C cable is plugged in with reversed (CC2) orientation, typec_set_orientation() is a no-op and usb_1_qmpphy stays stuck in TYPEC_ORIENTATION_NORMAL, breaking SuperSpeed USB. Omitting port@0 also violates Documentation/devicetree/bindings/connector/usb-connector.yaml. > + > &usb_1 { > status =3D "okay"; > }; [Severity: Medium] Just below &usb_1, are vdda-phy-supply and vdda-pll-supply swapped in &usb_1_qmpphy (introduced earlier in this series in commit "arm64: dts: qcom: add LG V60 ThinQ 5G (timelm) support")? &usb_1_qmpphy currently sets: vdda-phy-supply =3D <&vreg_l9a_1p2>; vdda-pll-supply =3D <&vreg_l18a_0p9>; On SM8250 QMP PHYs, vdda-phy-supply is the 0.9V core rail (vreg_l18a_0p9) and vdda-pll-supply is the 1.2V PLL rail (vreg_l9a_1p2). Because qmp_phy_vreg_l in drivers/phy/qualcomm/phy-qcom-qmp-combo.c requests 21800 uA on vdda-phy and 36000 uA on vdda-pll, swapping the supplies programs inverted load votes on the two LDOs when &usb_1 brings the PHY up. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261117123946.6685= 57-1-rofikcoga@gmail.com?part=3D10