From: sashiko-bot@kernel.org
To: "Emfox Zhou" <emfox@debian.org>
Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH] HID: intel-thc-hid: intel-thc: raw spinlocks for registers
Date: Wed, 18 Nov 2026 07:06:01 +0000 [thread overview]
Message-ID: <sashiko-outbox-220287@kernel.org> (raw)
In-Reply-To: <20261118065704.672557-1-emfox@debian.org>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] HID: intel-thc-hid: missing Fixes trailer for thc_regmap_cfg raw
spinlock fix
--
commit 68e15b8b74f173320164f31790193df2ee43dccc
Author: Emfox Zhou <emfox@debian.org>
> HID: intel-thc-hid: intel-thc: raw spinlocks for registers
>
> The primary interrupt handlers of intel-quickspi, intel-quicki2c and
> intel-ipts reach the registers from hardirq context. The map is a fast_io
> one, so its lock is a spinlock_t, which on PREEMPT_RT is a sleeping lock:
> taking it there is an invalid wait context.
>
> Ask for a raw spinlock instead. The accessors only touch MMIO, and the map
> is fast_io precisely because it is used where sleeping is not possible, so
> nothing else changes.
>
> Signed-off-by: Emfox Zhou <emfox@debian.org>
[Severity: Low]
Since this fixes an invalid wait context when accessing thc_regmap_cfg
from hardirq handlers, should this include a Fixes tag?
Fixes: 1b2d05384c29 ("HID: intel-thc-hid: Add basic THC driver skeleton")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118065704.672557-1-emfox@debian.org?part=1
prev parent reply other threads:[~2026-11-18 7:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 6:57 [PATCH] HID: intel-thc-hid: intel-thc: raw spinlocks for registers Emfox Zhou
2026-11-18 7:06 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-220287@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=emfox@debian.org \
--cc=linux-input@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox