From: sashiko-bot@kernel.org
To: "Abdur Rofik" <rofikcoga@gmail.com>
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-input@vger.kernel.org, robh@kernel.org,
conor+dt@kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH v2 02/10] arm64: dts: qcom: add LG V60 ThinQ 5G (timelm) support
Date: Wed, 18 Nov 2026 12:36:28 +0000 [thread overview]
Message-ID: <sashiko-outbox-220917@kernel.org> (raw)
In-Reply-To: <20261118120714.31505-3-rofikcoga@gmail.com>
Thank you for your contribution! Sashiko AI review found 5 potential
issues to consider:
- [High] arm64: dts: qcom: invalid smps6 in regulators-1 aborts
rpmh_regulator_probe()
- [Medium] arm64: dts: qcom: conflicting reg and memory-region on
simple-framebuffer
- [Medium] arm64: dts: qcom: missing board-specific firmware-name on
cdsp and gpu_zap_shader
- [Low] arm64: dts: qcom: duplicate sdc2_sleep_state node and redundant
pon status
- [Low] arm64: dts: qcom: non-power-of-two pmsg-size in ramoops is
rounded down
--
commit 3fe02ddb83035271fb02be5f0c325bb78269f75e
Author: Abdur Rofik <rofikcoga@gmail.com>
arm64: dts: qcom: add LG V60 ThinQ 5G (timelm) support
This commit adds the initial device tree and MAINTAINERS entry for the
SM8250-based LG V60 ThinQ 5G (timelm) smartphone.
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-lg-timelm.dts b/arch/arm64/boot/dts/qcom/sm8250-lg-timelm.dts
> new file mode 100644
> index 0000000000000..1b2b67486fee7
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm8250-lg-timelm.dts
> @@ -0,0 +1,615 @@
[ ... ]
> + chosen {
> + stdout-path = "serial0:115200n8";
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + framebuffer@9c000000 {
> + compatible = "simple-framebuffer";
> + reg = <0x0 0x9c000000 0x0 (1080 * 2460 * 4)>;
> + width = <1080>;
> + height = <2460>;
> + stride = <(1080 * 4)>;
> + format = "a8r8g8b8";
> + memory-region = <&cont_splash_mem>;
> + };
> + };
[Severity: Medium]
Should framebuffer@9c000000 drop memory-region (or drop reg and the unit
address) instead of specifying both?
When both properties are present, simplefb_get_memory_of() in simpledrm
and simplefb_parse_dt() in simplefb emit a boot warning ("preferring
"memory-region" over "reg" property") and ignore the exact framebuffer
size in reg in favor of the full 0x1200000-byte cont_splash_mem region,
allowing fb_mmap() on /dev/fb0 to map the trailing reserved memory beyond
the framebuffer.
[ ... ]
> + ramoops: ramoops@b0000000 {
> + compatible = "ramoops";
> + reg = <0x0 0xb0000000 0x0 0x280000>;
> + record-size = <0x40000>;
> + console-size = <0x40000>;
> + ftrace-size = <0x40000>;
> + pmsg-size = <0x1c0000>;
> + no-map;
> + };
[Severity: Low]
Is pmsg-size = <0x1c0000> intended here? ramoops_probe() requires
pmsg_size to be a power of two and rounds 0x1c0000 down to 0x100000 via
rounddown_pow_of_two(), shifting the buffer offsets and leaving the
remaining 0xc0000 bytes to dump_mem_sz.
[ ... ]
> + regulators-1 {
> + compatible = "qcom,pm8150l-rpmh-regulators";
> + qcom,pmic-id = "c";
[ ... ]
> + vreg_bob: bob {
> + regulator-name = "vreg_bob";
> + regulator-min-microvolt = <3008000>;
> + regulator-max-microvolt = <4000000>;
> + regulator-initial-mode = <RPMH_REGULATOR_MODE_AUTO>;
> + };
> +
> + vreg_s6c_0p88: smps6 {
> + regulator-name = "vreg_s6c_0p88";
> + regulator-min-microvolt = <348000>;
> + regulator-max-microvolt = <1000000>;
> + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> + };
[Severity: High]
Does defining smps6 under regulators-1 cause rpmh_regulator_probe() to
fail with -ENODEV?
On SM8250 with PM8150L (qcom,pmic-id = "c"), SMPS6C is an ARC level
resource (ebi.lvl) rather than a VRM resource, so cmd_db_read_addr() in
rpmh_regulator_init_vreg() returns 0 for "smpc6" and aborts probing
regulators-1 before smps8 (vreg_s8c_1p35) and ldo1..ldo11 are registered.
That leaves the parent supplies for PM8150 and PM8009 LDOs as well as the
UFS, SDHC2, and USB PHY rails unregistered.
As on other SM8250 boards, vreg_s6c_0p88 should be a top-level
regulator-fixed node at 880000 uV, and the 348000..1000000 uV rail under
regulators-1 should be smps7 (vreg_s7c_0p35).
[ ... ]
> +&cdsp {
> + status = "okay";
> +};
[ ... ]
> +&gpu {
> + status = "okay";
> +
> + zap-shader {
> + firmware-name = "qcom/sm8250/a650_zap.mbn";
> + };
> +};
[Severity: Medium]
Should &cdsp and the GPU zap-shader specify board-specific firmware-name
paths?
Enabling &cdsp without firmware-name causes qcom_pas_probe() to fall back
to bare "cdsp.mdt", and using the generic reference-board path
"qcom/sm8250/a650_zap.mbn" fails PAS authentication on fused retail
devices that require OEM-signed firmware (and zap-shader can be referenced
directly via &gpu_zap_shader).
[ ... ]
> +&pon {
> + status = "okay";
> +};
[ ... ]
> + sdc2_sleep_state: sdc2-sleep-state {
> + clk-pins {
> + pins = "sdc2_clk";
> + drive-strength = <2>;
> + bias-disable;
> + };
> +
> + cmd-pins {
> + pins = "sdc2_cmd";
> + drive-strength = <2>;
> + bias-pull-up;
> + };
> +
> + data-pins {
> + pins = "sdc2_data";
> + drive-strength = <2>;
> + bias-pull-up;
> + };
> + };
[Severity: Low]
This isn't a bug, but sdc2_sleep_state duplicates the identical node
already defined in sm8250.dtsi, and &pon is already enabled in
pm8150.dtsi. Also, the commit message mentions "High-Speed USB on
PM8150B", whereas &usb_1_hsphy is the SoC-internal HS PHY supplied by
PM8150.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118120714.31505-1-rofikcoga@gmail.com?part=2
next prev parent reply other threads:[~2026-11-18 12:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 12:07 [PATCH v2 00/10] arm64: dts: qcom: add LG V60 ThinQ 5G (timelm) support Abdur Rofik
2026-11-18 12:07 ` [PATCH v2 01/10] dt-bindings: arm: qcom: add LG V60 ThinQ 5G (timelm) Abdur Rofik
2026-11-18 12:07 ` [PATCH v2 02/10] arm64: dts: qcom: add LG V60 ThinQ 5G (timelm) support Abdur Rofik
2026-11-18 12:36 ` sashiko-bot [this message]
2026-11-18 12:07 ` [PATCH v2 03/10] dt-bindings: display: panel: add LG SW43103 Abdur Rofik
2026-11-18 12:07 ` [PATCH v2 04/10] drm/panel: add LG SW43103 panel driver Abdur Rofik
2026-11-18 12:07 ` [PATCH v2 05/10] dt-bindings: input: touchscreen: add Silicon Works SW42902 Abdur Rofik
2026-11-18 12:07 ` [PATCH v2 06/10] Input: touchscreen: add Silicon Works SW42902 support Abdur Rofik
2026-11-18 12:17 ` sashiko-bot
2026-11-18 12:07 ` [PATCH v2 07/10] arm64: dts: qcom: sm8250-lg-timelm: enable SW43103 panel Abdur Rofik
2026-11-18 12:26 ` sashiko-bot
2026-11-18 12:07 ` [PATCH v2 08/10] arm64: dts: qcom: sm8250-lg-timelm: add SW42902 touchscreen Abdur Rofik
2026-11-18 12:27 ` sashiko-bot
2026-11-18 12:07 ` [PATCH v2 09/10] arm64: dts: qcom: sm8250-lg-timelm: enable USB Type-C Abdur Rofik
2026-11-18 12:07 ` [PATCH v2 10/10] arm64: dts: qcom: sm8250-lg-timelm: add QCA6390 Bluetooth Abdur Rofik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-220917@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-input@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rofikcoga@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox