Linux Input/HID development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Geert Uytterhoeven" <geert+renesas@glider.be>
Cc: mfd@lists.linux.dev, linux-input@vger.kernel.org,
	dmitry.torokhov@gmail.com, lee@kernel.org
Subject: Re: [PATCH 3/4] input: serio: Enable compile-testing for SERIO_ASUS_TRANSFORMER_EC
Date: Thu, 19 Nov 2026 13:57:13 +0000	[thread overview]
Message-ID: <sashiko-outbox-223226@kernel.org> (raw)
In-Reply-To: <3beff0ff365277097d5678a9ee35fe8990f7e7da.1795095742.git.geert+renesas@glider.be>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] input: serio: missing I2C dependency for
  SERIO_ASUS_TRANSFORMER_EC
--

commit 9aac592895b890fc23d1336a836e2584fd6f0d20
Author: Geert Uytterhoeven <geert+renesas@glider.be>

input: serio: Enable compile-testing for SERIO_ASUS_TRANSFORMER_EC

This commit relaxes the Kconfig dependency of SERIO_ASUS_TRANSFORMER_EC
to allow compile-testing when MFD_ASUS_TRANSFORMER_EC is disabled.

> diff --git a/drivers/input/serio/Kconfig b/drivers/input/serio/Kconfig
> index 58d415ca1d540..87c78a8315fc3 100644
> --- a/drivers/input/serio/Kconfig
> +++ b/drivers/input/serio/Kconfig
> @@ -86,7 +86,7 @@ config SERIO_RPCKBD
>  
>  config SERIO_ASUS_TRANSFORMER_EC
>  	tristate "Asus Transformer's Dock keyboard and touchpad controller"
> -	depends on MFD_ASUS_TRANSFORMER_EC
> +	depends on MFD_ASUS_TRANSFORMER_EC || COMPILE_TEST

[Severity: Medium]
Should SERIO_ASUS_TRANSFORMER_EC also depend on I2C?

asus_ec_serio_write() calls i2c_smbus_write_word_data(), which is only
declared when CONFIG_I2C is enabled.  Without a dependency on I2C,
enabling COMPILE_TEST allows building the driver with CONFIG_I2C=n (which
fails compilation) or built-in with CONFIG_I2C=m (which fails linking).

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1795095742.git.geert+renesas@glider.be?part=3

  reply	other threads:[~2026-11-19 13:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 13:52 [PATCH 0/4] Improve MFD_ASUS_TRANSFORMER_EC dependencies Geert Uytterhoeven
2026-11-19 13:52 ` [PATCH 1/4] mfd: MFD_ASUS_TRANSFORMER_EC should depend on ARCH_TEGRA Geert Uytterhoeven
2026-11-19 13:52 ` [PATCH 2/4] input: keyboard: Enable compile-testing for KEYBOARD_ASUS_TRANSFORMER_EC Geert Uytterhoeven
2026-11-19 13:57   ` sashiko-bot
2026-11-19 13:52 ` [PATCH 3/4] input: serio: Enable compile-testing for SERIO_ASUS_TRANSFORMER_EC Geert Uytterhoeven
2026-11-19 13:57   ` sashiko-bot [this message]
2026-11-19 13:52 ` [PATCH 4/4] power: supply: Enable compile-testing for BATTERY_ASUS_TRANSFORMER_EC Geert Uytterhoeven
2026-11-19 13:59   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-223226@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=lee@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=mfd@lists.linux.dev \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox