From: Mohamed Ikbel Boulabiar <boulabiar@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Rafi Rubin <rafi@seas.upenn.edu>,
linux-input@vger.kernel.org, micki@n-trig.com, chatty@enac.fr
Subject: Re: [PATCH] Use TipSwitch for Touch
Date: Wed, 14 Apr 2010 10:15:04 +0200 [thread overview]
Message-ID: <t2u45cc95261004140115pda82ce66md30790d117888378@mail.gmail.com> (raw)
In-Reply-To: <20100414063242.GB9428@core.coreip.homeip.net>
Hi,
Maybe off-topic, but what about the support of Bamboo multitouch
devices from Wacom ?
http://www.wacom.com/bamboo/
M-I
On Wed, Apr 14, 2010 at 8:32 AM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Wed, Apr 14, 2010 at 01:04:54AM -0400, Rafi Rubin wrote:
>> TipSwitch is a better match for touch. Confidence and InRange work
>> for more current firmwares, but with some older versions only
>> TipSwitch is appropriate.
>>
>> Signed-off-by: Rafi Rubin <rafi@seas.upenn.edu>
>> ---
>> drivers/hid/hid-ntrig.c | 27 +++++++++++++++++++--------
>> 1 files changed, 19 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/hid/hid-ntrig.c b/drivers/hid/hid-ntrig.c
>> index 58ba0d3..071f86d 100644
>> --- a/drivers/hid/hid-ntrig.c
>> +++ b/drivers/hid/hid-ntrig.c
>> @@ -31,10 +31,12 @@ struct ntrig_data {
>> /* Incoming raw values for a single contact */
>> __u16 x, y, w, h;
>> __u16 id;
>> - __u8 confidence;
>> +
>> + bool tipswitch;
>> + bool confidence;
>> + bool first_contact_touch;
>>
>> bool reading_mt;
>> - __u8 first_contact_confidence;
>>
>> __u8 mt_footer[4];
>> __u8 mt_foot_count;
>> @@ -141,9 +143,10 @@ static int ntrig_event (struct hid_device *hid, struct hid_field *field,
>> case 0xff000001:
>> /* Tag indicating the start of a multitouch group */
>> nd->reading_mt = 1;
>> - nd->first_contact_confidence = 0;
>> + nd->first_contact_touch = 0;
>> break;
>> case HID_DG_TIPSWITCH:
>> + nd->tipswitch = value;
>> /* Prevent emission of touch until validated */
>> return 1;
>> case HID_DG_CONFIDENCE:
>> @@ -171,10 +174,17 @@ static int ntrig_event (struct hid_device *hid, struct hid_field *field,
>> * to emit a normal (X, Y) position
>> */
>> if (!nd->reading_mt) {
>> - input_report_key(input, BTN_TOOL_DOUBLETAP,
>> - (nd->confidence != 0));
>> + /*
>> + * TipSwitch indicates the presence of a
>> + * finger. Touch is the preferred event for
>> + * downstream support. DoubleTap is also
>> + * emitted to support proper operation with
>> + * the wacom X driver (for now).
>> + */
>
> I am not sure if we want to propagate unfortunate event selection in
> wacom drievr into other drivers. Any chance you could lend Ping hand in
> adding proper multitouch support to wacom X driver instead?
>
> --
> Dmitry
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-04-14 8:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 21:58 [PATCH 1/2] Emit TOUCH with DOUBLETAP for single touch Rafi Rubin
2010-04-09 21:58 ` [PATCH 2/2] Use TIPSWITCH for TOUCH Rafi Rubin
2010-04-13 13:31 ` Jiri Kosina
2010-04-13 20:04 ` Rafi Rubin
2010-04-14 5:04 ` [PATCH] Use TipSwitch for Touch Rafi Rubin
2010-04-14 6:32 ` Dmitry Torokhov
2010-04-14 7:51 ` Rafi Rubin
2010-04-14 8:07 ` Stéphane Chatty
2010-04-14 8:15 ` Mohamed Ikbel Boulabiar [this message]
2010-04-13 13:27 ` [PATCH 1/2] Emit TOUCH with DOUBLETAP for single touch Jiri Kosina
2010-04-13 20:01 ` Rafi Rubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=t2u45cc95261004140115pda82ce66md30790d117888378@mail.gmail.com \
--to=boulabiar@gmail.com \
--cc=chatty@enac.fr \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=micki@n-trig.com \
--cc=rafi@seas.upenn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).