public inbox for linux-input@vger.kernel.org
 help / color / mirror / Atom feed
From: Ferass El Hafidi <funderscore@postmarketos.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Hendrik Noack <hendrik-noack@gmx.de>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: Input: Add Wacom W9000-series penabled touchscreens
Date: Tue, 10 Mar 2026 17:08:46 +0000	[thread overview]
Message-ID: <tbp11w.2apu4pl02emnt@postmarketos.org> (raw)
In-Reply-To: <0200ee01-b14c-4fec-bbbb-b2a3c0f140f2@kernel.org>

On Tue, 10 Mar 2026 16:55, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>On 10/03/2026 17:50, Ferass El Hafidi wrote:
>> Hi Krzysztof & Hendrik,
>> 
>> On Mon, 09 Mar 2026 13:21, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>> On 09/03/2026 14:12, Hendrik Noack wrote:
>>>> Hello Krzysztof,
>>>>
>>>> 09.03.2026 13:56:41 Krzysztof Kozlowski <krzk@kernel.org>:
>>>>
>>>>> On 09/03/2026 13:54, Hendrik Noack wrote:
>>>>>> Hello Krzysztof,
>>>>>>
>>>>>> 08.03.2026 10:15:35 Krzysztof Kozlowski <krzk@kernel.org>:
>>>>>>
>>>>>>> You received review and instruction what to do. Did you read it?
>>>>>>
>>>>>> I read the review of Dmitry and incorporated it into this version.
>>>>>
>>>>> So you ignored my email completely or it did not reach you (it is on
>>>>> lore.kernel.org though)?
>>>>
>>>> I don't know what email you mean. You gave reviews on my first verison, 
>>>> which I already incorporated in v2 and then gave a review-by on v2, 
>>>> which I also added on v3, but now dropped, because I added a property
>>>> to the DT binding.
>>>
>>> The instruction I gave you when giving review.
>> 
>> If you gave review on the v3 dt-bindings, I can't find it on lore:
>> https://lore.kernel.org/all/20251205152858.14415-2-hendrik-noack@gmx.de/
>> 
>> On v2 you gave a R-b to the dt-bindings along with some instructions:
>> https://lore.kernel.org/all/2bf9dbd4-351e-4a79-9fcf-e41c5273d0be@kernel.org/
>> which were followed from what I can tell; your R-b was retained on v3,
>> but dropped on this revision (v4) because of new properties being added
>> (new `reset-gpio` property, technically also `wacom,w9002` compatible
>> but my understanding is new compatibles don't really matter much), as
>> your email said "Please add Acked-by/Reviewed-by/Tested-by tags when
>> posting new versions [...] unless patch changed (e.g. new properties
>> added to the DT bindings)".
>
>Thanks. I also provided the link further explaining what one has to do
>if one ever decide to drop the review.

Assuming you're talking about that R-b dropping should be mentioned in
the cover letter, that was probably just overlooked.

>
>Dropping it silently is for me rather sign I should ignore this patchset
>to avoid wasting time of lost reviews.

That was most likely not the intent, I think your feedback is valuable.

Best regards,
Ferass

[PS: I see you left some review after your last email, thank you for
     your time and sorry for the inconvenience.]

>
>Best regards,
>Krzysztof

  reply	other threads:[~2026-03-10 17:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-07 18:15 [PATCH v4 0/2] Add support for Wacom W9000-series penabled touchscreens Hendrik Noack
2026-03-07 18:15 ` [PATCH v4 1/2] dt-bindings: Input: Add " Hendrik Noack
2026-03-08  9:15   ` Krzysztof Kozlowski
2026-03-09 12:54     ` Hendrik Noack
2026-03-09 12:56       ` Krzysztof Kozlowski
2026-03-09 13:12         ` Hendrik Noack
2026-03-09 13:21           ` Krzysztof Kozlowski
2026-03-10 16:50             ` Ferass El Hafidi
2026-03-10 16:55               ` Krzysztof Kozlowski
2026-03-10 17:08                 ` Ferass El Hafidi [this message]
2026-03-10 16:58   ` Krzysztof Kozlowski
2026-03-10 17:29   ` Dmitry Torokhov
2026-03-07 18:15 ` [PATCH v4 2/2] Input: Add support for " Hendrik Noack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tbp11w.2apu4pl02emnt@postmarketos.org \
    --to=funderscore@postmarketos.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hendrik-noack@gmx.de \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox