From: Nikolas Koesling <nikolas@koesling.info>
To: sashiko-reviews@lists.linux.dev
Cc: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org
Subject: Re: [PATCH v6] HID: pulsar: add driver for Pulsar gaming mice
Date: Sun, 16 Aug 2026 14:03:24 +0200 [thread overview]
Message-ID: <x0pm_gy7QVChgX6PIKCvXA@koesling.info> (raw)
In-Reply-To: <20260816110521.8DB7E1F000E9@smtp.kernel.org>
> - [Critical] The `drvdata` structure is freed before the battery power supply is unregistered, leading to a Use-After-Free vulnerability if userspace reads battery properties during device removal.
`devres_release_all` releases all nodes in LIFO order.
`devm_kzalloc` and `devm_power_supply_register` are called on the same device, so the power supply is unregistered first.
> - [Medium] The fallback logic for non-Pulsar devices during battery initialization is bypassed on command timeout.
The dongle answers commands even while the mouse is off.
So if the command times out there is a protocol missmatch or the device is malfunctioning.
Not registering a battery in this case is the right behaviour.
> - [Low] Syntax error in the `model` buffer size will prevent compilation.
It compiles with gcc 16.1.1.
prev parent reply other threads:[~2026-08-16 12:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-16 10:54 [PATCH v6] HID: pulsar: add driver for Pulsar gaming mice Nikolas Koesling
2026-08-16 11:05 ` sashiko-bot
2026-08-16 12:03 ` Nikolas Koesling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x0pm_gy7QVChgX6PIKCvXA@koesling.info \
--to=nikolas@koesling.info \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox