Re: [PATCH] Support for the eGalax dual-touch panel

[Christoph Fritz <chf.fritz@googlemail.com>]

2010/4/12 Dmitry Torokhov <dmitry.torokhov@gmail.com>:
> On Sat, Apr 10, 2010 at 08:00:59PM +0200, Stéphane Chatty wrote:
>>
>> Le 10 avr. 10 à 18:04, Christoph Fritz a écrit :
>>
>> >Am Samstag, den 10.04.2010, 16:43 +0200 schrieb Stephane Chatty:
>> >>Added support for the eGalax dual-touch panel, found on the Asus
>> >>EeePC T101MT
>> >
>> >>+static void egalax_remove(struct hid_device *hdev)
>> >>+{
>> >>+   hid_hw_stop(hdev);
>> >>+   kfree(hid_get_drvdata(hdev));
>> >>+   hid_set_drvdata(hdev, NULL);
>> >>+}
>> >
>> >Why not using hid_hw_stop() instead of hid_set_drvdata()?
>> >
>
> It is used 2 lines above, isn't it?

sure, that's why I asked (overdetermined)

>
>>
>> Er, actually for a previous driver Dmitry suggested to add this line
>> and I did it without trying to understand :-)
>>
>
> You normally want to reset any pointers you set before, unless core does
> this for you. As far as I know only i2c guys decided to move that into
> core so far.

Should we do this too in a long run?
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html