From: "Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>,
peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca
Cc: jsnitsel@redhat.com, hdegoede@redhat.com, oe-lkp@lists.linux.dev,
lkp@intel.com, peterz@infradead.org, linux@mniewoehner.de,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
l.sanfilippo@kunbus.com, lukas@wunner.de,
p.rosenberger@kunbus.com
Subject: Re: [PATCH 1/2] tpm, tpm_tis: Handle interrupt storm
Date: Tue, 23 May 2023 10:07:27 +0300 [thread overview]
Message-ID: <058e2e0f-70b4-a506-3ada-2578b99e9163@linux.intel.com> (raw)
In-Reply-To: <c772bcdf-8256-2682-857c-9a6d344606d0@linux.intel.com>
On 23/05/2023 09:48, Péter Ujfalusi wrote:
>> static void tpm_tis_gen_interrupt(struct tpm_chip *chip)
>> @@ -804,6 +857,15 @@ static void tpm_tis_gen_interrupt(struct tpm_chip *chip)
>> chip->flags &= ~TPM_CHIP_FLAG_IRQ;
>> }
>>
>> +static void tpm_tis_free_irq_func(struct work_struct *work)
>> +{
>> + struct tpm_tis_data *priv = container_of(work, typeof(*priv), free_irq_work);
>> + struct tpm_chip *chip = priv->chip;
>> +
>> + devm_free_irq(chip->dev.parent, priv->irq, chip);
>> + priv->irq = 0;
>
> Should disable_interrupts() be called instead (with the locality
> request/relinquish)?
>
> Is there a chance of a race or is a race matters?
Nevermind this comment, it is good.
--
Péter
next prev parent reply other threads:[~2023-05-23 7:06 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 14:31 [PATCH 1/2] tpm, tpm_tis: Handle interrupt storm Lino Sanfilippo
2023-05-22 14:31 ` [PATCH 2/2] tpm, tpm_tis: reuse code in disable_interrupts() Lino Sanfilippo
2023-05-22 22:45 ` Jerry Snitselaar
2023-05-23 7:08 ` Péter Ujfalusi
2023-05-23 19:07 ` Jarkko Sakkinen
2023-05-23 20:52 ` Lino Sanfilippo
2023-05-24 1:29 ` Jarkko Sakkinen
2023-05-22 22:44 ` [PATCH 1/2] tpm, tpm_tis: Handle interrupt storm Jerry Snitselaar
2023-05-23 6:48 ` Péter Ujfalusi
2023-05-23 7:07 ` Péter Ujfalusi [this message]
2023-05-23 7:44 ` Lukas Wunner
2023-05-23 9:14 ` Péter Ujfalusi
2023-05-23 9:20 ` Hans de Goede
2023-05-23 9:35 ` Péter Ujfalusi
2023-05-23 10:35 ` Lino Sanfilippo
2023-05-23 15:19 ` Lukas Wunner
2023-05-23 10:41 ` Lino Sanfilippo
2023-05-23 15:16 ` Lukas Wunner
2023-05-24 9:08 ` Hans de Goede
2023-05-29 10:44 ` Michael Niewöhner
2023-05-23 19:35 ` Jarkko Sakkinen
2023-05-23 18:53 ` Jarkko Sakkinen
2023-05-23 19:00 ` Jarkko Sakkinen
2023-05-23 19:46 ` Lukas Wunner
2023-05-24 1:44 ` Jarkko Sakkinen
2023-05-23 20:50 ` Lino Sanfilippo
2023-05-23 19:12 ` Jarkko Sakkinen
2023-05-23 22:32 ` Jerry Snitselaar
2023-05-24 1:21 ` Jarkko Sakkinen
2023-05-23 19:37 ` Lukas Wunner
2023-05-24 1:46 ` Jarkko Sakkinen
2023-05-23 20:46 ` Lino Sanfilippo
2023-05-29 6:46 ` Péter Ujfalusi
2023-05-29 13:15 ` Lino Sanfilippo
2023-06-06 16:42 ` Jarkko Sakkinen
2023-05-30 17:56 ` Jerry Snitselaar
2023-06-06 16:35 ` Jarkko Sakkinen
2023-06-06 16:45 ` Jarkko Sakkinen
2023-05-24 3:58 ` Jarkko Sakkinen
2023-05-24 3:59 ` Jarkko Sakkinen
2023-05-24 7:29 ` Lukas Wunner
2023-05-24 15:30 ` Jarkko Sakkinen
2023-05-26 0:37 ` Lino Sanfilippo
2023-05-30 10:31 ` Lino Sanfilippo
2023-05-25 23:45 ` Lino Sanfilippo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=058e2e0f-70b4-a506-3ada-2578b99e9163@linux.intel.com \
--to=peter.ujfalusi@linux.intel.com \
--cc=LinoSanfilippo@gmx.de \
--cc=hdegoede@redhat.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=jsnitsel@redhat.com \
--cc=l.sanfilippo@kunbus.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@mniewoehner.de \
--cc=lkp@intel.com \
--cc=lukas@wunner.de \
--cc=oe-lkp@lists.linux.dev \
--cc=p.rosenberger@kunbus.com \
--cc=peterhuewe@gmx.de \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox