From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Haener, Michael" <michael.haener@siemens.com>,
"linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
"krzk@kernel.org" <krzk@kernel.org>
Cc: "Sverdlin, Alexander" <alexander.sverdlin@siemens.com>,
"jarkko@kernel.org" <jarkko@kernel.org>,
"jgg@ziepe.ca" <jgg@ziepe.ca>,
"peterhuewe@gmx.de" <peterhuewe@gmx.de>,
"robh@kernel.org" <robh@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"lukas@wunner.de" <lukas@wunner.de>
Subject: Re: [PATCH 2/2] dt-bindings: tpm: Add st,st33ktpm2xi2c to TCG TIS binding
Date: Sat, 13 Apr 2024 23:13:46 +0200 [thread overview]
Message-ID: <08ec46be-971f-4234-b65c-96992b5b0a87@linaro.org> (raw)
In-Reply-To: <85fa06dfb9bb69443ce86e10b8c4619317cccb3e.camel@siemens.com>
On 13/04/2024 22:26, Haener, Michael wrote:
> On Sat, 2024-04-13 at 10:38 +0200, Krzysztof Kozlowski wrote:
>> On 13/04/2024 09:15, M. Haener wrote:
>>> From: Michael Haener <michael.haener@siemens.com>
>>>
>>> Add the ST chip st33ktpm2xi2c to the supported compatible strings
>>> of the
>>> TPM TIS I2C schema. The Chip is compliant with the TCG PC Client
>>> TPM
>>> Profile specification.
>>>
>>> For reference, a datasheet is available at:
>>> https://www.st.com/resource/en/data_brief/st33ktpm2xi2c.pdf
>>>
>>> Reviewed-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
>>> Signed-off-by: Michael Haener <michael.haener@siemens.com>
>>> ---
>>
>>
>> Not tested...
>
> I was only able to verify and test the conformity of the ST chip
> st33ktpm2xi2c with kernel 6.1, so I left out the test-by tag.
I don't mean your tag. Your SoB means you tested it, but I meant you did
not send the binding for testing via automation.
> Unfortunately, there is no newer kernel for my embedded hardware.
>
>>
>> Please use scripts/get_maintainers.pl to get a list of necessary
>> people
>> and lists to CC. It might happen, that command when run on an older
>> kernel, gives you outdated entries. Therefore please be sure you base
>> your patches on recent Linux kernel.
>>
>> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
>> people, so fix your workflow. Tools might also fail if you work on
>> some
>> ancient tree (don't, instead use mainline), work on fork of kernel
>> (don't, instead use mainline) or you ignore some maintainers (really
>> don't). Just use b4 and everything should be fine, although remember
>> about `b4 prep --auto-to-cc` if you added new patches to the
>> patchset.
>>
>> You missed at least devicetree list (maybe more), so this won't be
>> tested by automated tooling.
>
> I called the script scripts/get_maintainer.pl on the latest kernel
> version for each of the two patches and added the output list to the
> individual patches accordingly. And only for the cover-letter I linked
> the two lists together.
> I understand now that I should have sent the whole series to both
> lists.
>
No, that's not the case. You did not Cc output of get_maintainer.pl.
Read *AGAIN* my message..
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-13 21:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-13 7:15 [PATCH 0/2] Add ST33KTPM2XI2C chip to the TPM TIS I2C driver M. Haener
2024-04-13 7:15 ` [PATCH 1/2] tpm: tis_i2c: Add compatible string st,st33ktpm2xi2c M. Haener
2024-04-13 21:45 ` Jarkko Sakkinen
2024-04-13 7:15 ` [PATCH 2/2] dt-bindings: tpm: Add st,st33ktpm2xi2c to TCG TIS binding M. Haener
2024-04-13 8:10 ` Krzysztof Kozlowski
2024-04-13 10:18 ` Lukas Wunner
2024-04-13 10:23 ` Krzysztof Kozlowski
2024-04-13 10:34 ` Lukas Wunner
2024-04-13 10:43 ` Krzysztof Kozlowski
2024-04-13 10:51 ` Lukas Wunner
2024-04-13 10:53 ` Krzysztof Kozlowski
2024-04-13 10:56 ` Lukas Wunner
2024-04-13 11:01 ` Krzysztof Kozlowski
2024-04-14 5:42 ` Haener, Michael
2024-04-14 5:52 ` Krzysztof Kozlowski
2024-04-13 21:49 ` Jarkko Sakkinen
2024-04-13 8:38 ` Krzysztof Kozlowski
2024-04-13 20:26 ` Haener, Michael
2024-04-13 21:13 ` Krzysztof Kozlowski [this message]
2024-04-13 21:47 ` Jarkko Sakkinen
2024-04-13 21:48 ` Krzysztof Kozlowski
2024-04-13 21:50 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08ec46be-971f-4234-b65c-96992b5b0a87@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alexander.sverdlin@siemens.com \
--cc=conor+dt@kernel.org \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=michael.haener@siemens.com \
--cc=peterhuewe@gmx.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox