From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: "Matthew Garrett" <mjg59@google.com>,
"Loïc Yhuel" <loic.yhuel@gmail.com>
Cc: linux-integrity <linux-integrity@vger.kernel.org>,
Ard Biesheuvel <ardb@kernel.org>,
Javier Martinez Canillas <javierm@redhat.com>
Subject: Re: [PATCH] tpm: check event log version before reading final events
Date: Thu, 14 May 2020 13:53:59 +0300 [thread overview]
Message-ID: <116341780ff56884d2f03aa9b90a8f9566b91540.camel@linux.intel.com> (raw)
In-Reply-To: <CACdnJuv8OyQpO4achWJb2HeB8Jb6Ejq9LsG64659JSay-a9O5A@mail.gmail.com>
On Tue, 2020-05-12 at 13:08 -0700, Matthew Garrett wrote:
> On Mon, May 11, 2020 at 9:01 PM Loïc Yhuel <loic.yhuel@gmail.com> wrote:
>
> > We get an event log in the SHA-1 format, which doesn't have a
> > tcg_efi_specid_event_head in the first event, and there is a final events
> > table which doesn't match the crypto agile format.
>
> This seems like a firmware bug, but we definitely shouldn't fail as a result.
>
> Reviewed-by: Matthew Garrett <mjg59@google.com>
So it is clear that "pr_warn(FW_BUG ..." would be a sane to have there.
/Jarkko
next prev parent reply other threads:[~2020-05-14 10:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 4:01 [PATCH] tpm: check event log version before reading final events Loïc Yhuel
2020-05-12 6:44 ` Ard Biesheuvel
2020-05-12 11:40 ` Loïc Yhuel
2020-05-12 12:30 ` Ard Biesheuvel
2020-05-14 10:51 ` Jarkko Sakkinen
2020-05-14 1:09 ` Jarkko Sakkinen
2020-05-14 8:10 ` Ard Biesheuvel
2020-05-14 23:44 ` Jarkko Sakkinen
2020-05-12 17:45 ` Javier Martinez Canillas
2020-05-12 18:45 ` Jerry Snitselaar
2020-05-12 20:08 ` Matthew Garrett
2020-05-14 10:53 ` Jarkko Sakkinen [this message]
2020-05-14 11:28 ` Loïc Yhuel
2020-05-14 11:31 ` Ard Biesheuvel
2020-05-15 0:03 ` Jarkko Sakkinen
2020-05-14 11:33 ` Javier Martinez Canillas
2020-05-14 12:28 ` Ard Biesheuvel
2020-05-14 12:56 ` Javier Martinez Canillas
2020-05-14 13:04 ` Ard Biesheuvel
2020-05-14 13:51 ` Javier Martinez Canillas
2020-05-14 18:06 ` Matthew Garrett
2020-05-15 15:55 ` Loïc Yhuel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=116341780ff56884d2f03aa9b90a8f9566b91540.camel@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=ardb@kernel.org \
--cc=javierm@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=loic.yhuel@gmail.com \
--cc=mjg59@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox