public inbox for linux-integrity@vger.kernel.org
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Raul Rangel <rrangel@chromium.org>
Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
	Eric Snowberg <eric.snowberg@oracle.com>,
	Amir Goldstein <amir73il@gmail.com>
Subject: Re: [PATCH v3] ima: detect changes to the backing overlay file
Date: Wed, 25 Oct 2023 11:09:28 -0400	[thread overview]
Message-ID: <145a91c7044c08928646f65850a518febcf5a5ca.camel@linux.ibm.com> (raw)
In-Reply-To: <CAHQZ30BSD2c4WwUTARx9OeqTjusgq7te8OzwdUi6Qk+L=9vSgA@mail.gmail.com>

On Wed, 2023-10-25 at 08:59 -0600, Raul Rangel wrote:
> On Wed, Oct 25, 2023 at 8:39 AM Mimi Zohar <zohar@linux.ibm.com> wrote:
> > +               if (!IS_I_VERSION(backing_inode) ||
> > +                   backing_inode->i_sb->s_dev != iint->real_dev ||
> > +                   backing_inode->i_ino != iint->real_ino ||
> > +                   !inode_eq_iversion(backing_inode, iint->version)) {
> > +                       iint->flags &= ~IMA_DONE_MASK;
> > +                       iint->measured_pcrs = 0;
> > +               }
> > +       }
> > +
> Does this mean I need to mount ext4 with `-o iversion`? Or has it been
> enabled by default?

According to commit 1ff20307393e ("ext4: unconditionally enable the
i_version counter")  it's now enabled by default.
> 
> I can test this patch out sometime this week and verify it fixes the
> performance regression.
> 
> Thanks!

Much appreciated!

-- 
thanks,

Mimi


  reply	other threads:[~2023-10-25 15:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-25 14:39 [PATCH v3] ima: detect changes to the backing overlay file Mimi Zohar
2023-10-25 14:59 ` Raul Rangel
2023-10-25 15:09   ` Mimi Zohar [this message]
2023-10-25 16:27 ` Eric Snowberg
2023-10-25 18:01   ` Mimi Zohar
2023-10-26 15:31     ` Raul Rangel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=145a91c7044c08928646f65850a518febcf5a5ca.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=amir73il@gmail.com \
    --cc=eric.snowberg@oracle.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rrangel@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox