From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Matthew Garrett <mjg59@google.com>
Cc: linux-integrity <linux-integrity@vger.kernel.org>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>
Subject: Re: Writing out EVM protected xattrs while EVM is active
Date: Tue, 17 Oct 2017 22:53:45 -0400 [thread overview]
Message-ID: <1508295225.4513.123.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <CACdnJuscweoJFresHzoQ_va9-eokz12VMz_T2kpJb-iJeSbGzg@mail.gmail.com>
On Tue, 2017-10-17 at 19:13 -0700, Matthew Garrett wrote:
> On Tue, Oct 17, 2017 at 7:08 PM, Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
> > On Tue, 2017-10-17 at 19:02 -0700, Matthew Garrett wrote:
> >
> >> Is this accurate? If there's no IMA policy that covers the file in
> >> question (eg, appraise is limited to a specific security context or
> >> owner), will IMA_NEW ever be set? It looks like that codepath will
> >> only be entered if there's a rule that matches. The EVM xattr
> >> protections appear to be called regardless, which means that there's
> >> then no way to write out attributes on them at runtime.
> >
> > Updating/writing security.evm is triggered by writing or updating ANY
> > file metadata included in the HMAC calculation. There is no
> > requirement for security.ima to exist.
>
> In this case there's no symmetric key loaded, so security.evm won't be
> updated. Here's what's happening:
>
> 1) Configure an IMA policy that only appraises a subset of files
> 2) Create a new file that does not match the appraisal rule.
> IMA_NEW_FILE isn't set because no rule matched.
> 3) Attempt to write security.ima, security.capability and security.evm
> on the new file. EVM blocks this because IMA_NEW_FILE isn't set.
Are you writing these xattrs before or after you closed the file?
Once the file is closed, even if the IMA_NEW_FILE flag had been set,
it would be removed.
This normally works because the file would have been hashed and
written out as security.ima, causing security.evm to be written out as
well.
> I may be misdiagnosing this, but as far as I can tell IMA_NEW_FILE is
> only set in ima_appraise_measurement() if action is set to something,
> and if ima_match_rules() doesn't match then this will never be the
> case?
True, but having IMA_NEW_FILE set would only help with writing the
first xattr, not subsequent ones.
next prev parent reply other threads:[~2017-10-18 2:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 23:12 Writing out EVM protected xattrs while EVM is active Matthew Garrett
2017-10-18 1:49 ` Mimi Zohar
2017-10-18 2:02 ` Matthew Garrett
2017-10-18 2:08 ` Mimi Zohar
2017-10-18 2:13 ` Matthew Garrett
2017-10-18 2:53 ` Mimi Zohar [this message]
2017-10-18 17:27 ` Matthew Garrett
2017-10-18 17:51 ` Mimi Zohar
2017-10-18 18:08 ` Matthew Garrett
2017-10-18 18:19 ` Mimi Zohar
2017-10-18 18:23 ` Matthew Garrett
2017-10-18 18:38 ` Mimi Zohar
[not found] ` <CACE9dm_vpTi705PJxGZkeNWUyHALZzVc2x=RUw_p=DZCPZfoXw@mail.gmail.com>
2017-10-18 18:18 ` Matthew Garrett
2017-10-19 11:14 ` Dmitry Kasatkin
2017-10-18 18:19 ` Dmitry Kasatkin
2017-10-19 11:00 ` Dmitry Kasatkin
2017-10-19 17:06 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508295225.4513.123.camel@linux.vnet.ibm.com \
--to=zohar@linux.vnet.ibm.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=linux-integrity@vger.kernel.org \
--cc=mjg59@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).