From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Matthew Garrett <mjg59@google.com>, linux-integrity@vger.kernel.org
Subject: Re: [PATCH] EVM: Allow userland to permit modification of EVM-protected xattrs
Date: Fri, 20 Oct 2017 06:10:21 -0400 [thread overview]
Message-ID: <1508494221.3268.70.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171019225739.4196-1-mjg59@google.com>
> diff --git a/security/integrity/evm/evm_secfs.c b/security/integrity/evm/evm_secfs.c
> index 319cf16d6603..0ce5134d3de5 100644
> --- a/security/integrity/evm/evm_secfs.c
> +++ b/security/integrity/evm/evm_secfs.c
> @@ -81,6 +81,10 @@ static ssize_t evm_write_key(struct file *file, const char __user *buf,
> return ret;
> /* Forbid further writes after the symmetric key is loaded */
> i |= EVM_SETUP;
> + /* Don't allow protected xattr modification if a
> + * symmetric key is loaded
> + */
> + i &= ~(EVM_PERMIT_XATTR_WRITES);
> }
>
> evm_initialized |= i;
Is "|= i" now correct?
prev parent reply other threads:[~2017-10-20 10:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 22:57 [PATCH] EVM: Allow userland to permit modification of EVM-protected xattrs Matthew Garrett
2017-10-20 10:10 ` Mimi Zohar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1508494221.3268.70.camel@linux.vnet.ibm.com \
--to=zohar@linux.vnet.ibm.com \
--cc=linux-integrity@vger.kernel.org \
--cc=mjg59@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).