linux-integrity.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Roberto Sassu <roberto.sassu@huawei.com>,
	Matthew Garrett <mjg59@google.com>,
	James Morris <james.l.morris@oracle.com>
Cc: Patrick Ohly <patrick.ohly@intel.com>,
	linux-integrity <linux-integrity@vger.kernel.org>
Subject: Re: IMA appraisal master plan?
Date: Thu, 16 Nov 2017 08:06:35 -0500	[thread overview]
Message-ID: <1510837595.3711.420.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <8bbaea89-336c-d14b-2ed8-44cd0a0d3ed1@huawei.com>

On Thu, 2017-11-16 at 10:23 +0100, Roberto Sassu wrote:
> On 11/16/2017 3:13 AM, Mimi Zohar wrote:
> > On Wed, 2017-11-15 at 16:05 -0800, Matthew Garrett wrote:
> >> On Wed, Nov 15, 2017 at 4:02 PM, James Morris <james.l.morris@oracle.com> wrote:
> >>> On Wed, 15 Nov 2017, Patrick Ohly wrote:
> >>>
> >>>> I have some experience with SMACK, but not with Apparmor. At least with
> >>>> SMACK the problem is that the LSM depends on integrity protection of
> >>>> the xattrs, but the integrity protection itself depends on the LSM, so
> >>>> there's a cycle. An attacker can much too easily make offline changes
> >>>> which then defeat whatever IMA policy the system might be using.
> >>>
> >>> Isn't this what EVM is supposed to mitigate?
> 
> With the default appraisal policy, it can't. IMA determines if a file
> must be appraised depending on metadata whose integrity has not been
> verified yet. A root process is able to load appraised files with
> i_uid = 0 and files with missing/invalid HMAC and i_uid != 0, at the
> same time.

The LSMs are responsible for protecting their own labels.  They have
the opportunity to verify and deny access to files based on LSM
labels, BEFORE IMA-appraisal is called to verify the file's integrity.

Look at security/security.c and see that IMA is called AFTER the
LSMs.  The same is true for the other IMA hooks, that are not co-
located with LSM hooks.  For example, the security_file_open hook is
called before the ima_file_check() hook.

Mimi

  parent reply	other threads:[~2017-11-16 13:06 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-07 15:17 [PATCH V6] EVM: Add support for portable signature format Matthew Garrett
2017-11-08 19:37 ` Mimi Zohar
2017-11-15 17:26 ` IMA appraisal master plan? (was: Re: [PATCH V6] EVM: Add support for portable signature format) Patrick Ohly
2017-11-15 17:58   ` Matthew Garrett
2017-11-15 18:21     ` Patrick Ohly
2017-11-15 18:28       ` Matthew Garrett
2017-11-16  0:02       ` James Morris
2017-11-16  0:05         ` Matthew Garrett
2017-11-16  2:13           ` Mimi Zohar
2017-11-16  9:23             ` IMA appraisal master plan? Roberto Sassu
2017-11-16 10:20               ` Patrick Ohly
2017-11-16 13:13                 ` Mimi Zohar
2017-11-16 14:18                 ` Roberto Sassu
2017-11-16 13:06               ` Mimi Zohar [this message]
2017-11-17 12:20                 ` Roberto Sassu
2017-11-17 13:42                   ` Mimi Zohar
2017-11-17 14:32                     ` Roberto Sassu
2017-11-17 15:58                     ` Stephen Smalley
2017-11-17 20:09                       ` Safford, David (GE Global Research, US)
2017-11-18 19:29                       ` Casey Schaufler
2017-11-19 20:47                   ` James Morris
2017-11-20 10:20                     ` Patrick Ohly
2017-11-20 14:59                       ` Mimi Zohar
2017-11-20 16:15                         ` Patrick Ohly
2017-11-21 10:05                         ` James Morris
2017-11-21  9:33                       ` Roberto Sassu
2017-11-21 14:05                         ` Mimi Zohar
2017-11-21 15:25                           ` Roberto Sassu
2017-11-21 15:53                             ` Mimi Zohar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1510837595.3711.420.camel@linux.vnet.ibm.com \
    --to=zohar@linux.vnet.ibm.com \
    --cc=james.l.morris@oracle.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=mjg59@google.com \
    --cc=patrick.ohly@intel.com \
    --cc=roberto.sassu@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).