public inbox for linux-integrity@vger.kernel.org
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Matthew Garrett <mjg59@google.com>, linux-integrity@vger.kernel.org
Subject: Re: [USER] [PATCH V2] Add support for portable EVM format
Date: Thu, 16 Nov 2017 15:01:53 -0500	[thread overview]
Message-ID: <1510862513.3711.457.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171116182111.26267-1-mjg59@google.com>

Hi Matthew,

> @@ -1679,6 +1692,9 @@ int main(int argc, char *argv[])
>  		case 'i':
>  			evm_immutable = true;
>  			break;
> +		case 'o':
> +			evm_portable = true;
> +			break;

If this is ok by you,  I'll make the change:

-                       evm_immutable = true;
+                       if (evm_portable)
+                               log_err("Portable and immutable options are exclusive, ignoring immutable option.");
+                       else
+                               evm_immutable = true;
+                       break;
+               case 'o':
+                       if (evm_immutable)
+                               log_err("Portable and immutable options are exclusive, ignoring portable option.");
+                       else
+                               evm_portable = true;


+                       else
+                               evm_portable = true;
                        break;

Mimi

  reply	other threads:[~2017-11-16 20:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-16 18:21 [USER] [PATCH V2] Add support for portable EVM format Matthew Garrett
2017-11-16 20:01 ` Mimi Zohar [this message]
2017-11-16 20:52   ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1510862513.3711.457.camel@linux.vnet.ibm.com \
    --to=zohar@linux.vnet.ibm.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=mjg59@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox