public inbox for linux-integrity@vger.kernel.org
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Dongsu Park <dongsu@kinvolk.io>,
	linux-kernel@vger.kernel.org, Alban Crequy <alban@kinvolk.io>,
	Miklos Szeredi <miklos@szeredi.hu>,
	Seth Forshee <seth.forshee@canonical.com>,
	linux-integrity <linux-integrity@vger.kernel.org>
Subject: Re: [PATCH 0/2] turn on force option for FUSE in builtin policies
Date: Mon, 15 Jan 2018 16:00:23 -0500	[thread overview]
Message-ID: <1516050023.6607.57.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180115171825.GA28088@infradead.org>

On Mon, 2018-01-15 at 09:18 -0800, Christoph Hellwig wrote:
> On Mon, Jan 15, 2018 at 11:32:41AM -0500, Mimi Zohar wrote:
> > For XFS, which considers fsmagic numbers private to the filesystem,
> > *always* using the fsmagic number is wrong.  As to whether this is
> > true for other filesystems is unclear.  IMA policies have been defined
> > in terms of fsmagic numbers for a long time.  fsmagic numbers were
> > moved from the filesystems to magic.h for this purpose.  Someone would
> > have complained earlier if it is always wrong.
> >  
> > I just posted a patch titled "ima: define new policy condition based
> > on the filesystem name" to allow policies to be defined in terms of
> > the i_sb->s_type->name.
> 
> ima has no business looking at either the name _or_ the magic number.

There are a couple of reasons to define policies in terms of the
filesystem name or magic numbers.

One example is pseudo filesystems (eg. pseudo filesystems - sysfs,
securitys, cgroups, selinuxfs, etc).  These should never be measured
or appraised.

The current example is fuse and remote file systems.  These should
always be re-evaluated and not rely on cached file info.

If not based on IMA policy, what do you propose?  Define new SB_ flags
 to indicate IMA disabled/enabled (eg. SB_IMA) and nocaching (eg.
SB_IMA_NOCACHE)?

Mimi

  reply	other threads:[~2018-01-15 21:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1515682581.git.dongsu@kinvolk.io>
2018-01-11 19:51 ` [PATCH 1/2] fs/fuse: move SUPER_MAGIC definitions to linux/magic.h Dongsu Park
2018-01-11 19:51 ` [PATCH 2/2] ima: turn on force option for FUSE in builtin policies Dongsu Park
2018-01-12 15:33   ` Mimi Zohar
2018-01-14 19:09   ` kbuild test robot
2018-01-16 10:47     ` Dongsu Park
     [not found] ` <20180115144804.GA28856@infradead.org>
2018-01-15 16:32   ` [PATCH 0/2] " Mimi Zohar
2018-01-15 17:18     ` Christoph Hellwig
2018-01-15 21:00       ` Mimi Zohar [this message]
2018-01-16 10:41   ` [PATCH] ima,fuse: introduce new fs flag FS_NO_IMA_CACHE Alban Crequy
2018-01-16 11:26     ` Alban Crequy
2018-01-16 11:35       ` Mimi Zohar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1516050023.6607.57.camel@linux.vnet.ibm.com \
    --to=zohar@linux.vnet.ibm.com \
    --cc=alban@kinvolk.io \
    --cc=dongsu@kinvolk.io \
    --cc=hch@infradead.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=seth.forshee@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox