From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>,
"Bruno E. O. Meneguele" <brdeoliv@redhat.com>,
dmitry.kasatkin@gmail.com, jarkko.sakkinen@linux.intel.com
Cc: linux-integrity@vger.kernel.org
Subject: Re: [PATCH] ima-evm-utils: migrate to the new openssl 1.1 api
Date: Sun, 28 Jan 2018 08:37:50 -0800 [thread overview]
Message-ID: <1517157470.3082.14.camel@HansenPartnership.com> (raw)
In-Reply-To: <1517116029.29187.214.camel@linux.vnet.ibm.com>
On Sun, 2018-01-28 at 00:07 -0500, Mimi Zohar wrote:
> On Fri, 2018-01-26 at 22:23 -0800, James Bottomley wrote:
> >
> > On Thu, 2017-12-07 at 17:05 -0200, Bruno E. O. Meneguele wrote:
> > >
> > > This patch adds and changes the points needed to support the new
> > > OpenSSL 1.1 API, considering the older one, OpenSSL 1.0.z, will
> > > be dropped by the major distros in following releases.
> >
> > This would break compilation on every 1.0 distro:
> >
> > gcc -DHAVE_CONFIG_H -I. -I.. -I.. -include config.h -g -O2 -g
> > -O1
> > -Wall -Wstrict-prototypes -pipe -MT evmctl-evmctl.o -MD -MP -MF
> > .deps/evmctl-evmctl.Tpo -c -o evmctl-evmctl.o `test -f 'evmctl.c'
> > ||
> > echo './'`evmctl.c
> > evmctl.c: In function 'calc_evm_hash':
> > evmctl.c:369:2: warning: implicit declaration of function
> > 'EVP_MD_CTX_new' [-Wimplicit-function-declaration]
> > ctx = EVP_MD_CTX_new();
> > ...
> >
> > Unfortunately you have to ifdef the compilations if you want it to
> > work on both 1.0 and 1.1.
> >
> > How about this?
>
> Thanks, James. It compiles and works with both libraries now.
Great, thanks for testing (I only compile tested). I'll send this as a
formal patch with your tested by.
James
prev parent reply other threads:[~2018-01-28 16:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 19:05 [PATCH] ima-evm-utils: migrate to the new openssl 1.1 api Bruno E. O. Meneguele
2018-01-27 6:23 ` James Bottomley
2018-01-28 5:07 ` Mimi Zohar
2018-01-28 16:37 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517157470.3082.14.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=brdeoliv@redhat.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-integrity@vger.kernel.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox