Re: [PATCH] ima-evm-utils: migrate to the new openssl 1.1 api

James Bottomley
2018-01-28T16:37:52Z

On Sun, 2018-01-28 at 00:07 -0500, Mimi Zohar wrote:
> On Fri, 2018-01-26 at 22:23 -0800, James Bottomley wrote:
> >
> > On Thu, 2017-12-07 at 17:05 -0200, Bruno E. O. Meneguele wrote:
> > >
> > > This patch adds and changes the points needed to support the new
> > > OpenSSL 1.1 API, considering the older one, OpenSSL 1.0.z, will
> > > be dropped by the major distros in following releases.
> >
> > This would break compilation on every 1.0 distro:
> >
> > gcc -DHAVE_CONFIG_H -I. -I.. -I.. -include config.h -g -O2 -g
> > -O1
> > -Wall -Wstrict-prototypes -pipe -MT evmctl-evmctl.o -MD -MP -MF
> > .deps/evmctl-evmctl.Tpo -c -o evmctl-evmctl.o `test -f 'evmctl.c'
> > ||
> > echo './'`evmctl.c
> > evmctl.c: In function 'calc_evm_hash':
> > evmctl.c:369:2: warning: implicit declaration of function
> > 'EVP_MD_CTX_new' [-Wimplicit-function-declaration]
> > ctx = EVP_MD_CTX_new();
> > ...
> >
> > Unfortunately you have to ifdef the compilations if you want it to
> > work on both 1.0 and 1.1.
> >
> > How about this?
>
> Thanks, James. It compiles and works with both libraries now.

Great, thanks for testing (I only compile tested). I'll send this as a
formal patch with your tested by.

James