Linux Integrity Measurement development
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.vnet.ibm.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>,
	linux-integrity@vger.kernel.org
Subject: Re: [PATCH] ima-evm-utils: Add backward compatible support for openssl 1.1
Date: Sun, 28 Jan 2018 12:52:47 -0500	[thread overview]
Message-ID: <1517161967.29187.262.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <1517161157.3082.41.camel@HansenPartnership.com>

On Sun, 2018-01-28 at 09:39 -0800, James Bottomley wrote:
> On Sun, 2018-01-28 at 08:41 -0800, James Bottomley wrote:
> > Openssl 1.1 is really annoying in that it made certain objects opaque
> > and added accessors for the necessary components, but these accessors
> > often don't exist in 1.0 and before, so there's no way to create
> > clean code that will compile with both 1.0 and 1.1; instead you have
> > to compiled with both code bases to make sure everything is working.
> > 
> > The other problem is that since the structures are opaque, their size
> > isn't known, so having a structure declared as a variable is no
> > longer possible.
> > 
> > This change switches all uses of EVP_MD_CTX to be pointers
> > initialised with the correct EVP_MD_CTX_new() (not available in 1.0),
> > does the same for HMAC_CTX, and uses the 1.1 only primitive
> > RSA_get0_key() to extract the public modulus and exponent from an RSA
> > key.
> > 
> > Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com
> > >
> > Tested-by: Mimi Zohar <zohar@linux.vnet.ibm.com>
> 
> OK, let me try that again without the line breaks.

Definitely a lot better.

Mimi

      reply	other threads:[~2018-01-28 17:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-28 16:41 [PATCH] ima-evm-utils: Add backward compatible support for openssl 1.1 James Bottomley
2018-01-28 17:39 ` James Bottomley
2018-01-28 17:52   ` Mimi Zohar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1517161967.29187.262.camel@linux.vnet.ibm.com \
    --to=zohar@linux.vnet.ibm.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=linux-integrity@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox