From: Oliver Neukum <oneukum@suse.com>
To: "David R. Bild" <david.bild@xaptum.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-integrity@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 1/2] usb: misc: xapea00x: add driver for Xaptum ENF Access Card
Date: Tue, 08 May 2018 11:09:19 +0200 [thread overview]
Message-ID: <1525770559.24345.10.camel@suse.com> (raw)
In-Reply-To: <CAAi9uDuhR+X37aedWjmrPssr4RjgzuJoJ4vL7md1fMsHq5ASJQ@mail.gmail.com>
Am Montag, den 07.05.2018, 08:31 -0500 schrieb David R. Bild :
> > > + spi_master->flags = 0;
> > > + spi_master->setup = xapea00x_spi_setup;
> > > + spi_master->transfer_one_message = xapea00x_spi_transfer_one_message;
> > > +
> > > + retval = spi_register_master(spi_master);
> > > +
> > > + if (retval)
> > > + goto free_spi;
> > > +
> > > + dev->spi_master = spi_master;
> >
> > Race condition.
> >
>
> What race condition do you see? (I appreciate the review, but need
> some more specific help here.)
Hi,
you have registered the master. So it is functional, but if any
callback goes for dev->spi_master at that point, it will read an
incorrect value.
HTH
Oliver
next prev parent reply other threads:[~2018-05-08 9:15 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180430125418.31344-1-david.bild@xaptum.com>
2018-05-04 13:00 ` [PATCH v3 0/2] Add driver for Xaptum ENF Access card (XAP-EA-00x) David R. Bild
2018-05-04 13:00 ` [PATCH v3 1/2] usb: misc: xapea00x: add driver for Xaptum ENF Access Card David R. Bild
2018-05-07 9:58 ` Oliver Neukum
2018-05-07 13:31 ` David R. Bild
2018-05-08 9:09 ` Oliver Neukum [this message]
2018-05-04 13:00 ` [PATCH v3 2/2] usb: misc: xapea00x: perform platform initialization of TPM David R. Bild
2018-05-04 19:06 ` Jason Gunthorpe
2018-05-04 19:56 ` David R. Bild
2018-05-04 20:19 ` David R. Bild
2018-05-06 15:02 ` Jason Gunthorpe
2018-05-10 1:42 ` Jarkko Sakkinen
2018-05-08 10:55 ` Jarkko Sakkinen
2018-05-08 15:25 ` James Bottomley
2018-05-08 15:29 ` David R. Bild
2018-05-08 15:36 ` James Bottomley
2018-05-10 1:59 ` Jarkko Sakkinen
2018-05-10 14:31 ` David R. Bild
2018-05-13 8:51 ` Jarkko Sakkinen
2018-05-25 20:31 ` Ken Goldman
2018-05-10 14:25 ` David R. Bild
2018-05-10 14:47 ` James Bottomley
2018-05-10 15:17 ` David R. Bild
2018-05-25 20:23 ` Ken Goldman
2018-05-10 1:44 ` Jarkko Sakkinen
2018-05-10 14:29 ` David R. Bild
2018-05-10 1:42 ` Jarkko Sakkinen
2018-05-10 14:41 ` David R. Bild
2018-05-13 8:46 ` Jarkko Sakkinen
2018-05-14 19:31 ` Jason Gunthorpe
2018-05-14 19:59 ` David R. Bild
2018-05-14 20:08 ` Jason Gunthorpe
2018-05-14 20:12 ` David R. Bild
2018-05-07 14:12 ` EXTERNAL: " Jeremy Boone
2018-05-08 10:47 ` Jarkko Sakkinen
2018-05-10 14:09 ` David R. Bild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525770559.24345.10.camel@suse.com \
--to=oneukum@suse.com \
--cc=david.bild@xaptum.com \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).